apr-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Greg Stein <gst...@lyra.org>
Subject Re: [PATCH] Buckets: add copy function, ap_bucket_split_any(), etc
Date Fri, 08 Dec 2000 11:11:08 GMT
On Fri, Dec 08, 2000 at 12:59:19AM -0800, Cliff Woolley wrote:
> 
> Hey...
> 
>    Here's a patch (sorry it took me so long) that adds a copy function to the bucket
> API.  It also incorporates the ap_bucket_split_any() patch that was finally agreed
> upon after much debate a month or so ago, but which never got committed.  I've
> combined the two because there's also now an ap_bucket_copy_any() as well.  I hope
> somebody has a chance to commit this before Friday's Alpha release.

I've applied the patch because it is a good start.

However, ap_bucket_split_any() is not yet right. If a caller says "split at
10000", then it will probably fail because the read() won't read in that
much. You need to read enough buckets, until you read the bucket that
contains the split point. *then* do the split.

The basic point is that the caller doesn't know how much you're going to
read(), so it can't know the range for a proper value.

Cheers,
-g

-- 
Greg Stein, http://www.lyra.org/

Mime
View raw message