apr-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Greg Stein <gst...@lyra.org>
Subject Re: [PATCH] apr_make_os_sock()
Date Mon, 04 Dec 2000 08:19:24 GMT
On Sun, Dec 03, 2000 at 11:38:32AM -0800, rbb@covalent.net wrote:
> 
> > > > Here is enough to look at to make sure I didn't screw anything up.  I
> > > > added family and type parameters too so that APR doesn't have to bend
> > > > over backwards (i.e., use syscalls) to find that out.  We don't keep
> > > > the type anywhere yet but it is likely to become useful in the future.
> > > 
> > > I would really prefer that this function at least look like the current
> > > apr_put_os_* functions.  That would mean just wrapping all of this
> > > information up into a single structure that is just passed to APR's create
> > > function.
> > 
> > What is the purpose of putting the parameters into a structure?  Do we
> > expect that we'll want to tailor the information provided to
> > apr_make_os_socket() on certain platforms?
> 
> Won't it need to be different on different platforms?  I mean, Windows
> wants a SOCKET, and I wouldn't put it past M$ to change the sockaddr to
> some windows specific structure in the future.

The prototype will be the same... that is why we have the apr_os_sock_t
type.

We shouldn't need to pass structures to apr_make_os_socket() (or other,
similar creation functions).

Cheers,
-g

-- 
Greg Stein, http://www.lyra.org/

Mime
View raw message