apr-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Greg Stein <gst...@lyra.org>
Subject Re: isascii on BeOS PPC
Date Sun, 03 Dec 2000 13:44:40 GMT
Ryan was discussing how that would be hard to use within apr_lib.h because
we'd need to include apr_private.h to get the config variable. etc etc

I didn't even know that check was in there, and figured the quick patch was
sufficient. Please feel free to fix it:

  1) update the #if stuff in apr_lib
or
  2) add logic to propagate the HAVE_isascii to APR_HAVE_isascii in apr.h

Essentially, that fix may have reached configure.in, but it didn't make it
to the apr_lib.h header.

Cheers,
-g

On Sun, Dec 03, 2000 at 01:18:01PM -0000, David Reid wrote:
> OK!  Timeout!
> 
> Can we please have a moment of sanity.  Why are we hard coding this?
> 
> >From configure.in...
> 
> AC_CHECK_DEFINE(isascii, ctype.h)
> 
> 
> We already have a check in configure so can we please use this???  I'll
> patch it in a while.  This was addressed for PPC compilation on BeOS at the
> very beginning of APR development... <sigh>
> 
> Sam, the folks at Be know about this omission from ctype.h in PPC R4.5 and
> it was fixed in R5, which is why it makes sense to have it as a configure
> time check than hard coding it.
> 
> david
> 
> > > +#if BEOS && __POWER_PC__
> > > +#define isascii(c) (((c) & ~0x7f)==0)
> > > +#endif
> 

-- 
Greg Stein, http://www.lyra.org/

Mime
View raw message