apr-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Sam TH <...@uchicago.edu>
Subject Re: isascii on BeOS PPC
Date Sun, 03 Dec 2000 08:02:56 GMT
On Sat, Dec 02, 2000 at 11:33:55PM -0800, rbb@covalent.net wrote:
> 
> First of all, Sam could you please post patches in line?  It makes them
> much easier to reply to.  Thanks.

Sure.  Sorry about that. 

> 
> Now, quick question.
> 
> Index: network_io/beos/Makefile.in
> ===================================================================
> RCS file: /home/cvspublic/apr/network_io/beos/Makefile.in,v
> retrieving revision 1.14
> diff -u -r1.14 Makefile.in
> --- network_io/beos/Makefile.in	2000/11/18 16:53:18	1.14
> +++ network_io/beos/Makefile.in	2000/12/03 07:21:51
> @@ -6,7 +6,7 @@
>  INCDIR=../../include
>  OSDIR=$(INCDIR)/arch/@OSDIR@
>  DEFOSDIR=$(INCDIR)/arch/@DEFAULT_OSDIR@
> -INCLUDES=-I$(INCDIR) -I$(OSDIR) -I$(DEFOSDIR)
> +INCLUDES=-I$(INCDIR) -I$(OSDIR) -I$(DEFOSDIR) -I../unix/
>  MKDEP=../../helpers/mkdep.sh
>  
>  LIB=libnetwork.a
> 
> Why is this needed?  There are no header files in network_io/unix, so
> adding -I../unix/ shouldn't add anything here.  Could you please make sure
> that you are working with an up-to-date repository?

You would think so, wouldn't you?  But someone decided to be tricky
and include a .c file (sa_common.c) in sockaddr.c, so the additional
include directory is neccessary.

           
	sam th		     
	sam@uchicago.edu
	http://www.abisource.com/~sam/
	GnuPG Key:  
	http://www.abisource.com/~sam/key

Mime
View raw message