Mailing-List: contact dev-help@apr.apache.org; run by ezmlm
Sender: trawick@bellsouth.net
To: Greg Stein <gstein@lyra.org>
Cc: dev@apr.apache.org
Subject: Re: [PATCH] small step toward's David Reid's IPv6 patch
References: <200011151935.OAA32436@adsl-77-241-65.rdu.bellsouth.net>
	<20001115122721.X5983@lyra.org>
From: Jeff Trawick <trawickj@bellsouth.net>
Date: 15 Nov 2000 17:04:02 -0500
In-Reply-To: Greg Stein's message of "Wed, 15 Nov 2000 12:27:21 -0800"
Message-ID: <m3bsvgyjsd.fsf@adsl-77-241-65.rdu.bellsouth.net>
Lines: 26
User-Agent: Gnus/5.0807 (Gnus v5.8.7) Emacs/20.3
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii

Greg Stein <gstein@lyra.org> writes:

> On Wed, Nov 15, 2000 at 02:35:56PM -0500, Jeff Trawick wrote:
> > I started with the part of David's patch which uses apr_sockaddr_t
> > instead of sockaddr_in inside apr_socket_t, got everything to compile
> > (and seem to run properly), and simplified some of the code which
> > allocates storage for apr_socket_t and fills out fields in
> > apr_sockaddr_t.
>
> Looks fine to me. Go for it.

will-do, but I'll wait until later this evening or tomorrow a.m. when
I will get a chance to get Win32 building with the changes...  

the use of sa_common.c assumes that certain fields in apr_socket_t are
the same across platforms, which means that the same sort of changes
are needed in the Win32, BeOS, and OS/2 code also...  

it is one thing to break the build for a platform I don't have
in-house, but yet another to break the build for a platform that sits
silent across the room :)

-- 
Jeff Trawick | trawick@ibm.net | PGP public key at web site:
     http://www.geocities.com/SiliconValley/Park/9289/
          Born in Roswell... married an alien...