Return-Path: Mailing-List: contact dev-help@apr.apache.org; run by ezmlm Delivered-To: mailing list dev@apr.apache.org Received: (qmail 34023 invoked from network); 29 Nov 2000 09:45:23 -0000 Received: from test.webdav.org (HELO kurgan.lyra.org) (198.144.203.199) by locus.apache.org with SMTP; 29 Nov 2000 09:45:23 -0000 Received: (from gstein@localhost) by kurgan.lyra.org (8.9.3/8.9.3) id BAA22965; Wed, 29 Nov 2000 01:47:23 -0800 X-Authentication-Warning: kurgan.lyra.org: gstein set sender to gstein@lyra.org using -f Date: Wed, 29 Nov 2000 01:47:23 -0800 From: Greg Stein To: dev@apr.apache.org, new-httpd@apache.org Subject: Re: cvs commit: apr apr_common.m4 hints.m4 Message-ID: <20001129014723.Q25840@lyra.org> Mail-Followup-To: dev@apr.apache.org, new-httpd@apache.org References: <20001128213154.19363.qmail@locus.apache.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline User-Agent: Mutt/1.2i In-Reply-To: <20001128213154.19363.qmail@locus.apache.org>; from rbb@locus.apache.org on Tue, Nov 28, 2000 at 09:31:54PM -0000 X-URL: http://www.lyra.org/greg/ X-Spam-Rating: locus.apache.org 1.6.2 0/1000/N On Tue, Nov 28, 2000 at 09:31:54PM -0000, rbb@locus.apache.org wrote: > rbb 00/11/28 13:31:53 > > Modified: src acinclude.m4 configure.in > . apr_common.m4 hints.m4 > Added: src hints.m4 > Log: > Split the hints file into two files, one in APR and one in Apache. The APR > hints file just sets build variables, the Apache hints file just sets > Apache variables. This is meant to clean up parts of APR, so that they > don't include Apache information. >... > --- apr_common.m4 2000/11/02 05:01:08 1.7 > +++ apr_common.m4 2000/11/28 21:31:52 1.8 >... > +dnl > +dnl APR_DOEXTRA > +dnl > +dnl Handle the use of EXTRA_* variables. > +dnl Basically, EXTRA_* vars are added to the > +dnl current settings of their "parents". We > +dnl can expand as needed. This is ugly > +dnl > +AC_DEFUN(APR_DOEXTRA, [ > + for i in CFLAGS LDFLAGS LIBS > + do > + eval APR_TMP=\$EXTRA_$i > + if test -n "$APR_TMP"; then > + eval $i=\"\$$i $APR_TMP\" > + eval export $i > + eval unset EXTRA_${i} > + eval export EXTRA_${i} > + fi > + done > +]) I see that this came from apr/hints.m4, but I don't understand what it is really doing here. What is this extra magic? AFAIK, all we need to do is set the variables, and that is that. No fancy export or anything. Cheers, -g -- Greg Stein, http://www.lyra.org/