apr-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Jeff Trawick <trawi...@bellsouth.net>
Subject Re: [PATCH] small step toward's David Reid's IPv6 patch
Date Wed, 15 Nov 2000 22:04:02 GMT
Greg Stein <gstein@lyra.org> writes:

> On Wed, Nov 15, 2000 at 02:35:56PM -0500, Jeff Trawick wrote:
> > I started with the part of David's patch which uses apr_sockaddr_t
> > instead of sockaddr_in inside apr_socket_t, got everything to compile
> > (and seem to run properly), and simplified some of the code which
> > allocates storage for apr_socket_t and fills out fields in
> > apr_sockaddr_t.
>
> Looks fine to me. Go for it.

will-do, but I'll wait until later this evening or tomorrow a.m. when
I will get a chance to get Win32 building with the changes...  

the use of sa_common.c assumes that certain fields in apr_socket_t are
the same across platforms, which means that the same sort of changes
are needed in the Win32, BeOS, and OS/2 code also...  

it is one thing to break the build for a platform I don't have
in-house, but yet another to break the build for a platform that sits
silent across the room :)

-- 
Jeff Trawick | trawick@ibm.net | PGP public key at web site:
     http://www.geocities.com/SiliconValley/Park/9289/
          Born in Roswell... married an alien...

Mime
View raw message