apr-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From r..@covalent.net
Subject Re: [PATCH] controlling the flavor of lock used by APR
Date Thu, 30 Nov 2000 18:44:06 GMT
On 30 Nov 2000, Jeff Trawick wrote:

> Important note: the hints.m4 change is just an example...  I won't
> commit a change for Linux, but will do so for OS/390 before I
> commit... 

Please use the APR_SETVAR syntax for setting variables in hints.m4.  This
keeps everything looking the same.

>      AC_CHECK_DEFINE(PTHREAD_PROCESS_SHARED, pthread.h)
>  fi
>  
> -AC_BEGIN_DECISION([ap_lock implementation method])
> +AC_BEGIN_DECISION([apr_lock implementation method])
>  AC_IFALLYES(custom:union_semun,
>              AC_DECIDE(USE_SYSVSEM_SERIALIZE, [SysV IPC semget()]))
>  AC_IFALLYES(header:sys/file.h define:LOCK_EX,
> @@ -627,7 +627,9 @@
>  AC_IFALLYES(header:pthread.h define:PTHREAD_PROCESS_SHARED dnl
>              custom:with_pthread_cross,
>              AC_DECIDE(USE_PROC_PTHREAD_SERIALIZE, [pthread mutex]))
> -dnl AC_DECISION_FORCE(USE_FCNTL_SERIALIZE)
> +if test "x$apr_lock_method" != "x"; then
> +    AC_DECISION_FORCE($apr_lock_method)
> +fi
>  AC_END_DECISION
>  AC_DEFINE_UNQUOTED($ac_decision)

Do we want a default method?  For example, the USE_xxx_SERIALIZE option
isn't set in hints.m4, and autoconf can't figure out what to use,
shouldn't we default to FCNTL?  Looking at the current code, this looks
broken, but we probably shouldn't propogate the problem.

Ryan
_______________________________________________________________________________
Ryan Bloom                        	rbb@apache.org
406 29th St.
San Francisco, CA 94131
-------------------------------------------------------------------------------


Mime
View raw message