apr-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From r..@covalent.net
Subject Re: cvs commit: apr apr_common.m4 hints.m4
Date Wed, 29 Nov 2000 19:18:30 GMT

> > > >   +AC_DEFUN(APR_DOEXTRA, [
> > > >   +  for i in CFLAGS LDFLAGS LIBS
> > > >   +  do
> > > >   +    eval APR_TMP=\$EXTRA_$i
> > > >   +    if test -n "$APR_TMP"; then
> > > >   +      eval $i=\"\$$i $APR_TMP\"
> > > >   +      eval export $i
> > > >   +      eval unset EXTRA_${i}
> > > >   +      eval export EXTRA_${i}
> > > >   +    fi
> > > >   +  done
> > > >   +])
> > 
> > Unfortunately, as Jim found when he first did this stuff, Autoconf doesn't
> > use the EXTRA_* variables, so this is a bit of a hack.
> 
> Ah. I think I understand. Wouldn't the above be simpler and more obvious if
> we wrote it like:
> 
> AC_DEFIN(APR_DOEXTRA, [
>   CFLAGS="$CFLAGS $EXTRA_CFLAGS"
>   EXTRA_CFLAGS=""
>   LDFLAGS="$LDFLAGS $EXTRA_LDFLAGS"
>   EXTRA_LDFLAGS=""
>   LIBS="$LIBS $EXTRA_LIBS"
>   EXTRA_LIBS=""
> ])
> 
> Presuming the above works as expected, then I'd like to change the code.

The docs really explain what is happening, and this will allow us to add
more EXTRA_ options later really cleanly.

Ryan
_______________________________________________________________________________
Ryan Bloom                        	rbb@apache.org
406 29th St.
San Francisco, CA 94131
-------------------------------------------------------------------------------



Mime
View raw message