apr-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Greg Stein <gst...@lyra.org>
Subject Re: cvs commit: apr apr_common.m4 hints.m4
Date Wed, 29 Nov 2000 20:54:50 GMT
On Wed, Nov 29, 2000 at 09:46:51PM +0100, Branko Cibej wrote:
> rbb@covalent.net wrote:
> 
> >> Ah. I think I understand. Wouldn't the above be simpler and more obvious if
> >> we wrote it like:
> >> 
> >> AC_DEFIN(APR_DOEXTRA, [
> >>   CFLAGS="$CFLAGS $EXTRA_CFLAGS"
> >>   EXTRA_CFLAGS=""
> >>   LDFLAGS="$LDFLAGS $EXTRA_LDFLAGS"
> >>   EXTRA_LDFLAGS=""
> >>   LIBS="$LIBS $EXTRA_LIBS"
> >>   EXTRA_LIBS=""
> >> ])
> >> 
> >> Presuming the above works as expected, then I'd like to change the code.
> > 
> > 
> > The docs really explain what is happening, and this will allow us to add
> > more EXTRA_ options later really cleanly.
> 
> These should be exported in APRVARS, too.

We've got EXTRA_CPPFLAGS, EXTRA_CFLAGS, and EXTRA_LIBS in there today.
Missing the LDFLAGS stuff.

Cheers,
-g

-- 
Greg Stein, http://www.lyra.org/

Mime
View raw message