apr-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From cove...@apache.org
Subject svn commit: r1744604 - /apr/apr/branches/1.5.x/poll/unix/z_asio.c
Date Thu, 19 May 2016 17:00:32 GMT
Author: covener
Date: Thu May 19 17:00:32 2016
New Revision: 1744604

URL: http://svn.apache.org/viewvc?rev=1744604&view=rev
Log:
poll/unix/z_asio.c:271]: (style) Suspicious condition (assignment +
comparison); Clarify expression with parentheses.

PR59582


Modified:
    apr/apr/branches/1.5.x/poll/unix/z_asio.c

Modified: apr/apr/branches/1.5.x/poll/unix/z_asio.c
URL: http://svn.apache.org/viewvc/apr/apr/branches/1.5.x/poll/unix/z_asio.c?rev=1744604&r1=1744603&r2=1744604&view=diff
==============================================================================
--- apr/apr/branches/1.5.x/poll/unix/z_asio.c (original)
+++ apr/apr/branches/1.5.x/poll/unix/z_asio.c Thu May 19 17:00:32 2016
@@ -268,9 +268,9 @@ static apr_status_t asio_pollset_create(
 
     if (flags & APR_POLLSET_THREADSAFE) {
 #if APR_HAS_THREADS
-        if (rv = apr_thread_mutex_create(&(priv->ring_lock),
+        if ((rv = apr_thread_mutex_create(&(priv->ring_lock),
                                            APR_THREAD_MUTEX_DEFAULT,
-                                           p) != APR_SUCCESS) {
+                                           p)) != APR_SUCCESS) {
             DBG1(1, "apr_thread_mutex_create returned %d\n", rv);
             pollset->p = NULL;
             return rv;



Mime
View raw message