apr-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From traw...@apache.org
Subject svn commit: r1671329 - in /apr/apr/trunk/build: apr_hints.m4 aprenv.py
Date Sat, 04 Apr 2015 20:52:49 GMT
Author: trawick
Date: Sat Apr  4 20:52:49 2015
New Revision: 1671329

URL: http://svn.apache.org/r1671329
Log:
Stop using -no-cpp-precomp on Darwin or OS X.  The Apple-modified gcc hasn't 
needed it in over a decade, and GNU gcc spews warnings about it.

Misty De Meo provided the best research:

    The last release I can find where -cpp-precomp did anything is 2.95.2 
    (Apple build 937.2), from the December 2002 Xcode, prior to the release
    of Xcode 1.0 (presumably the one that shipped with it): 
    http://opensource.apple.com/source/gcc/gcc-1640/gcc/gcc.c

    In subsequent releases -cpp-precomp and -no-cpp-precomp were both made
    no-ops. The last time they were mentioned was in the install.texi from
    Apple GCC build 1765, from the WWDC 2004 developer tools; it was already
    a no-op by then.

Submitted by: Neil Conway <nrc cs.berkeley.edu>, Misty De Meo <misty brew.sh>
Reviewed by: trawick

Modified:
    apr/apr/trunk/build/apr_hints.m4
    apr/apr/trunk/build/aprenv.py

Modified: apr/apr/trunk/build/apr_hints.m4
URL: http://svn.apache.org/viewvc/apr/apr/trunk/build/apr_hints.m4?rev=1671329&r1=1671328&r2=1671329&view=diff
==============================================================================
--- apr/apr/trunk/build/apr_hints.m4 (original)
+++ apr/apr/trunk/build/apr_hints.m4 Sat Apr  4 20:52:49 2015
@@ -183,7 +183,7 @@ dnl	       # Not a problem in 10.20.  Ot
 	APR_ADDTO(CPPFLAGS, [-DRHAPSODY])
 	;;
     *-apple-darwin*)
-        APR_ADDTO(CPPFLAGS, [-DDARWIN -DSIGPROCMASK_SETS_THREAD_MASK -no-cpp-precomp])
+        APR_ADDTO(CPPFLAGS, [-DDARWIN -DSIGPROCMASK_SETS_THREAD_MASK])
         APR_SETIFNULL(apr_posixsem_is_global, [yes])
         case $host in
             *-apple-darwin[[1-9]].*)

Modified: apr/apr/trunk/build/aprenv.py
URL: http://svn.apache.org/viewvc/apr/apr/trunk/build/aprenv.py?rev=1671329&r1=1671328&r2=1671329&view=diff
==============================================================================
--- apr/apr/trunk/build/aprenv.py (original)
+++ apr/apr/trunk/build/aprenv.py Sat Apr  4 20:52:49 2015
@@ -122,7 +122,7 @@ class APREnv(Environment):
   def APRHints(self):
     # TOOD: port more from apr_hints.m4
     if self['PLATFORM'] == 'darwin':
-      self.AppendUnique(CPPFLAGS=['-DDARWIN', '-DSIGPROCMASK_SETS_THREAD_MASK', '-no-cpp-precomp'])
+      self.AppendUnique(CPPFLAGS=['-DDARWIN', '-DSIGPROCMASK_SETS_THREAD_MASK'])
 
 
   def critical_value(self, f, value, *args):



Mime
View raw message