apr-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From j..@apache.org
Subject svn commit: r1561383 - /apr/apr/branches/1.5.x/shmem/unix/shm.c
Date Sat, 25 Jan 2014 20:07:45 GMT
Author: jim
Date: Sat Jan 25 20:07:44 2014
New Revision: 1561383

URL: http://svn.apache.org/r1561383
Log:
FIXME comment... 

Modified:
    apr/apr/branches/1.5.x/shmem/unix/shm.c

Modified: apr/apr/branches/1.5.x/shmem/unix/shm.c
URL: http://svn.apache.org/viewvc/apr/apr/branches/1.5.x/shmem/unix/shm.c?rev=1561383&r1=1561382&r2=1561383&view=diff
==============================================================================
--- apr/apr/branches/1.5.x/shmem/unix/shm.c (original)
+++ apr/apr/branches/1.5.x/shmem/unix/shm.c Sat Jan 25 20:07:44 2014
@@ -308,6 +308,7 @@ APR_DECLARE(apr_status_t) apr_shm_create
         }
 #endif /* APR_USE_SHMEM_MMAP_TMP */
 #if APR_USE_SHMEM_MMAP_SHM
+        /* FIXME: SysV uses 0600... should we? */
         tmpfd = shm_open(shm_name, O_RDWR | O_CREAT | O_EXCL, 0644);
         if (tmpfd == -1) {
             return errno;
@@ -534,6 +535,7 @@ APR_DECLARE(apr_status_t) apr_shm_attach
 #if APR_USE_SHMEM_MMAP_SHM
         const char *shm_name = make_shm_open_safe_name(filename, pool);
 
+        /* FIXME: SysV uses 0600... should we? */
         tmpfd = shm_open(shm_name, O_RDWR, 0644);
         if (tmpfd == -1) {
             return errno;



Mime
View raw message