apr-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From rj...@apache.org
Subject svn commit: r1200085 - /apr/apr-util/branches/1.5.x/test/testxml.c
Date Thu, 10 Nov 2011 01:38:24 GMT
Author: rjung
Date: Thu Nov 10 01:38:23 2011
New Revision: 1200085

URL: http://svn.apache.org/viewvc?rev=1200085&view=rev
Log:
Don't check return code for billion laugther test.

Otherwise test will fail when using builtin expat
(it does work for expat 2 but we only want to
test against the original billion laugther problem).

This is the same we do in 1.3.x.
Trunk is different, because we no longer support
builtin expat there.

Modified:
    apr/apr-util/branches/1.5.x/test/testxml.c

Modified: apr/apr-util/branches/1.5.x/test/testxml.c
URL: http://svn.apache.org/viewvc/apr/apr-util/branches/1.5.x/test/testxml.c?rev=1200085&r1=1200084&r2=1200085&view=diff
==============================================================================
--- apr/apr-util/branches/1.5.x/test/testxml.c (original)
+++ apr/apr-util/branches/1.5.x/test/testxml.c Thu Nov 10 01:38:23 2011
@@ -159,8 +159,9 @@ static void test_billion_laughs(abts_cas
                        APR_FOPEN_READ, 0, p);
     apr_assert_success(tc, "open billion-laughs.xml", rv);
 
-    rv = apr_xml_parse_file(p, &parser, &doc, fd, 2000);
-    ABTS_TRUE(tc, rv != APR_SUCCESS);
+    /* Don't test for return value; if it returns, chances are the bug
+     * is fixed or the machine has insane amounts of RAM. */
+    apr_xml_parse_file(p, &parser, &doc, fd, 2000);
 
     apr_file_close(fd);
 }



Mime
View raw message