apr-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From s.@apache.org
Subject svn commit: r1074876 - in /apr/apr/trunk: CHANGES include/apr_ring.h
Date Sat, 26 Feb 2011 16:55:06 GMT
Author: sf
Date: Sat Feb 26 16:55:06 2011
New Revision: 1074876

URL: http://svn.apache.org/viewvc?rev=1074876&view=rev
Log:
Makr APR_RING_HEAD pointers volatile to work around an aliasing problem that
causes gcc 4.5 to miscompile some brigade related code.

PR 50190

Modified:
    apr/apr/trunk/CHANGES
    apr/apr/trunk/include/apr_ring.h

Modified: apr/apr/trunk/CHANGES
URL: http://svn.apache.org/viewvc/apr/apr/trunk/CHANGES?rev=1074876&r1=1074875&r2=1074876&view=diff
==============================================================================
--- apr/apr/trunk/CHANGES [utf-8] (original)
+++ apr/apr/trunk/CHANGES [utf-8] Sat Feb 26 16:55:06 2011
@@ -1,6 +1,9 @@
                                                      -*- coding: utf-8 -*-
 Changes for APR 2.0.0
 
+  *) apr_ring: Workaround for aliasing problem that causes gcc 4.5 to
+     miscompile some brigade related code. PR 50190. [Stefan Fritsch]
+
   *) apr_file_flush_locked(): Handle short writes. [Stefan Fritsch]
 
   *) Add new configure option --enable-allocator-uses-mmap to use mmap

Modified: apr/apr/trunk/include/apr_ring.h
URL: http://svn.apache.org/viewvc/apr/apr/trunk/include/apr_ring.h?rev=1074876&r1=1074875&r2=1074876&view=diff
==============================================================================
--- apr/apr/trunk/include/apr_ring.h (original)
+++ apr/apr/trunk/include/apr_ring.h Sat Feb 26 16:55:06 2011
@@ -90,8 +90,8 @@
  */
 #define APR_RING_HEAD(head, elem)					\
     struct head {							\
-	struct elem *next;						\
-	struct elem *prev;						\
+	struct elem * volatile next;					\
+	struct elem * volatile prev;					\
     }
 
 /**



Mime
View raw message