Return-Path: Delivered-To: apmail-apr-commits-archive@www.apache.org Received: (qmail 49496 invoked from network); 4 Aug 2010 21:16:23 -0000 Received: from unknown (HELO mail.apache.org) (140.211.11.3) by 140.211.11.9 with SMTP; 4 Aug 2010 21:16:23 -0000 Received: (qmail 81454 invoked by uid 500); 4 Aug 2010 21:16:23 -0000 Delivered-To: apmail-apr-commits-archive@apr.apache.org Received: (qmail 81365 invoked by uid 500); 4 Aug 2010 21:16:22 -0000 Mailing-List: contact commits-help@apr.apache.org; run by ezmlm Precedence: bulk List-Post: List-Help: List-Unsubscribe: Reply-To: dev@apr.apache.org List-Id: Delivered-To: mailing list commits@apr.apache.org Received: (qmail 81358 invoked by uid 99); 4 Aug 2010 21:16:22 -0000 Received: from athena.apache.org (HELO athena.apache.org) (140.211.11.136) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 04 Aug 2010 21:16:22 +0000 X-ASF-Spam-Status: No, hits=-2000.0 required=10.0 tests=ALL_TRUSTED X-Spam-Check-By: apache.org Received: from [140.211.11.4] (HELO eris.apache.org) (140.211.11.4) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 04 Aug 2010 21:16:21 +0000 Received: by eris.apache.org (Postfix, from userid 65534) id 2034823889DD; Wed, 4 Aug 2010 21:15:04 +0000 (UTC) Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Subject: svn commit: r982408 - /apr/apr/trunk/memcache/apr_memcache.c Date: Wed, 04 Aug 2010 21:15:04 -0000 To: commits@apr.apache.org From: pgollucci@apache.org X-Mailer: svnmailer-1.0.8 Message-Id: <20100804211505.2034823889DD@eris.apache.org> Author: pgollucci Date: Wed Aug 4 21:15:02 2010 New Revision: 982408 URL: http://svn.apache.org/viewvc?rev=982408&view=rev Log: - Fix mismatched signed comparisons [1] - While here replace atoi with strtol(3) Reported by: sf via gcc Modified: apr/apr/trunk/memcache/apr_memcache.c Modified: apr/apr/trunk/memcache/apr_memcache.c URL: http://svn.apache.org/viewvc/apr/apr/trunk/memcache/apr_memcache.c?rev=982408&r1=982407&r2=982408&view=diff ============================================================================== --- apr/apr/trunk/memcache/apr_memcache.c (original) +++ apr/apr/trunk/memcache/apr_memcache.c Wed Aug 4 21:15:02 2010 @@ -787,10 +787,10 @@ apr_memcache_getp(apr_memcache_t *mc, length = apr_strtok(NULL, " ", &last); if (length) { - len = atoi(length); + len = strtol(length, (char **)NULL, 10); } - if (len < 0) { + if (len != 0 ) { *new_length = 0; *baton = NULL; } @@ -1358,14 +1358,14 @@ apr_memcache_multgetp(apr_memcache_t *mc length = apr_strtok(NULL, " ", &last); if (length) { - len = atoi(length); + len = strtol(length, (char **) NULL, 10); } value = apr_hash_get(values, key, strlen(key)); if (value) { - if (len >= 0) { + if (len != 0) { apr_bucket_brigade *bbb; apr_bucket *e;