apr-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From s.@apache.org
Subject svn commit: r980197 - /apr/apr/trunk/dbm/apr_dbm_sdbm.c
Date Wed, 28 Jul 2010 20:30:52 GMT
Author: sf
Date: Wed Jul 28 20:30:52 2010
New Revision: 980197

URL: http://svn.apache.org/viewvc?rev=980197&view=rev
Log:
For now, revert part of r979891 to fix test breakage. But the error handling
of apr_sdbm_nextkey seems broken.

Modified:
    apr/apr/trunk/dbm/apr_dbm_sdbm.c

Modified: apr/apr/trunk/dbm/apr_dbm_sdbm.c
URL: http://svn.apache.org/viewvc/apr/apr/trunk/dbm/apr_dbm_sdbm.c?rev=980197&r1=980196&r2=980197&view=diff
==============================================================================
--- apr/apr/trunk/dbm/apr_dbm_sdbm.c (original)
+++ apr/apr/trunk/dbm/apr_dbm_sdbm.c Wed Jul 28 20:30:52 2010
@@ -192,8 +192,11 @@ static apr_status_t vt_sdbm_nextkey(apr_
     pkey->dptr = rd.dptr;
     pkey->dsize = rd.dsize;
 
-    /* store any error info into DBM, and return a status code. */
-    return set_error(dbm, rv);
+    /*
+     * XXX: This discards any error but apr_sdbm_nextkey currently returns
+     * XXX: an error for the last key
+     */
+    return set_error(dbm, APR_SUCCESS);
 }
 
 static void vt_sdbm_freedatum(apr_dbm_t *dbm, apr_datum_t data)



Mime
View raw message