apr-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From b..@apache.org
Subject svn commit: r929069 - /apr/apr/trunk/file_io/os2/filestat.c
Date Tue, 30 Mar 2010 10:24:17 GMT
Author: bjh
Date: Tue Mar 30 10:24:17 2010
New Revision: 929069

URL: http://svn.apache.org/viewvc?rev=929069&view=rev
Log:
OS/2: Clean up some comment questions.
For the record:

/* XXX: No other possible types from FS3? */
No, FILESTATUS3 info can't specify any types besides regular file and directory
which is why we go on to test the file handle if possible.

>From DosQueryHType(), values in the low byte of filetype greater than 2 are
described as "reserved" by the API documentation so should never happen.

Modified:
    apr/apr/trunk/file_io/os2/filestat.c

Modified: apr/apr/trunk/file_io/os2/filestat.c
URL: http://svn.apache.org/viewvc/apr/apr/trunk/file_io/os2/filestat.c?rev=929069&r1=929068&r2=929069&view=diff
==============================================================================
--- apr/apr/trunk/file_io/os2/filestat.c (original)
+++ apr/apr/trunk/file_io/os2/filestat.c Tue Mar 30 10:24:17 2010
@@ -31,7 +31,6 @@ static void FS3_to_finfo(apr_finfo_t *fi
         finfo->filetype = APR_DIR;
     else
         finfo->filetype = APR_REG;
-    /* XXX: No other possible types from FS3? */
 
     finfo->user = 0;
     finfo->group = 0;
@@ -73,8 +72,7 @@ static apr_status_t handle_type(apr_file
             break;
 
         default:
-            /* Brian, is this correct???
-             */
+            /* Values greater than 2 are reserved, this should never happen */
             *ftype = APR_UNKFILE;
             break;
         }



Mime
View raw message