Return-Path: Delivered-To: apmail-apr-commits-archive@www.apache.org Received: (qmail 77106 invoked from network); 26 Jun 2009 05:51:29 -0000 Received: from hermes.apache.org (HELO mail.apache.org) (140.211.11.3) by minotaur.apache.org with SMTP; 26 Jun 2009 05:51:29 -0000 Received: (qmail 81207 invoked by uid 500); 26 Jun 2009 05:51:40 -0000 Delivered-To: apmail-apr-commits-archive@apr.apache.org Received: (qmail 81138 invoked by uid 500); 26 Jun 2009 05:51:40 -0000 Mailing-List: contact commits-help@apr.apache.org; run by ezmlm Precedence: bulk List-Post: List-Help: List-Unsubscribe: Reply-To: dev@apr.apache.org List-Id: Delivered-To: mailing list commits@apr.apache.org Received: (qmail 81128 invoked by uid 99); 26 Jun 2009 05:51:40 -0000 Received: from athena.apache.org (HELO athena.apache.org) (140.211.11.136) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 26 Jun 2009 05:51:40 +0000 X-ASF-Spam-Status: No, hits=-2000.0 required=10.0 tests=ALL_TRUSTED X-Spam-Check-By: apache.org Received: from [140.211.11.4] (HELO eris.apache.org) (140.211.11.4) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 26 Jun 2009 05:51:31 +0000 Received: by eris.apache.org (Postfix, from userid 65534) id 3BA3E2388896; Fri, 26 Jun 2009 05:51:11 +0000 (UTC) Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Subject: svn commit: r788591 - in /apr/apr/branches/1.3.x: ./ CHANGES locks/unix/proc_mutex.c Date: Fri, 26 Jun 2009 05:51:11 -0000 To: commits@apr.apache.org From: bojan@apache.org X-Mailer: svnmailer-1.0.8 Message-Id: <20090626055111.3BA3E2388896@eris.apache.org> X-Virus-Checked: Checked by ClamAV on apache.org Author: bojan Date: Fri Jun 26 05:51:10 2009 New Revision: 788591 URL: http://svn.apache.org/viewvc?rev=788591&view=rev Log: Backport r788588 from the trunk. Avoid proc mutex failures by checking for both EAGAIN and EWOULDBLOCK. Workaround for long standing Linux/hppa bug. Patch by Stefan Fritsch . Modified: apr/apr/branches/1.3.x/ (props changed) apr/apr/branches/1.3.x/CHANGES apr/apr/branches/1.3.x/locks/unix/proc_mutex.c Propchange: apr/apr/branches/1.3.x/ ------------------------------------------------------------------------------ --- svn:mergeinfo (original) +++ svn:mergeinfo Fri Jun 26 05:51:10 2009 @@ -1,2 +1,2 @@ /apr/apr/branches/1.4.x:783970 -/apr/apr/trunk:712674,733052,742752,747990,748361,748371,748565,748988,749810,782838,783398,783958 +/apr/apr/trunk:712674,733052,742752,747990,748361,748371,748565,748988,749810,782838,783398,783958,788588 Modified: apr/apr/branches/1.3.x/CHANGES URL: http://svn.apache.org/viewvc/apr/apr/branches/1.3.x/CHANGES?rev=788591&r1=788590&r2=788591&view=diff ============================================================================== --- apr/apr/branches/1.3.x/CHANGES [utf-8] (original) +++ apr/apr/branches/1.3.x/CHANGES [utf-8] Fri Jun 26 05:51:10 2009 @@ -1,6 +1,10 @@ -*- coding: utf-8 -*- Changes for APR 1.3.6 + *) On Linux/hppa flock() returns EAGAIN instead of EWOULDBLOCK. This + causes proc mutex failures. + [Stefan Fritsch ] + *) Set CLOEXEC flags where appropriate. Either use new O_CLOEXEC flag and associated functions, such as dup3(), accept4(), epoll_create1() etc., or simply set CLOEXEC flag using fcntl(). PR 46425. [Stefan Fritsch Modified: apr/apr/branches/1.3.x/locks/unix/proc_mutex.c URL: http://svn.apache.org/viewvc/apr/apr/branches/1.3.x/locks/unix/proc_mutex.c?rev=788591&r1=788590&r2=788591&view=diff ============================================================================== --- apr/apr/branches/1.3.x/locks/unix/proc_mutex.c (original) +++ apr/apr/branches/1.3.x/locks/unix/proc_mutex.c Fri Jun 26 05:51:10 2009 @@ -683,7 +683,7 @@ rc = flock(mutex->interproc->filedes, LOCK_EX | LOCK_NB); } while (rc < 0 && errno == EINTR); if (rc < 0) { - if (errno == EWOULDBLOCK) { + if (errno == EWOULDBLOCK || errno == EAGAIN) { return APR_EBUSY; } return errno;