Mailing-List: contact commits-help@apr.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@apr.apache.org
Content-Type: text/plain; charset="utf-8"
MIME-Version: 1.0
Content-Transfer-Encoding: 7bit
Subject: svn commit: r658946 - in /apr/apr-util/trunk: CHANGES test/dbd.c
 test/testmemcache.c
Date: Thu, 22 May 2008 00:09:19 -0000
To: commits@apr.apache.org
From: bojan@apache.org
Message-Id: <20080522000919.DA3922388A41@eris.apache.org>

Author: bojan
Date: Wed May 21 17:09:19 2008
New Revision: 658946

URL: http://svn.apache.org/viewvc?rev=658946&view=rev
Log:
Document that we're counting rows in DBD from 1.
Adjust DBD test to print rows from 1.
Remove an unused variable from memcache test.

Modified:
    apr/apr-util/trunk/CHANGES
    apr/apr-util/trunk/test/dbd.c
    apr/apr-util/trunk/test/testmemcache.c

Modified: apr/apr-util/trunk/CHANGES
URL: http://svn.apache.org/viewvc/apr/apr-util/trunk/CHANGES?rev=658946&r1=658945&r2=658946&view=diff
==============================================================================
--- apr/apr-util/trunk/CHANGES [utf-8] (original)
+++ apr/apr-util/trunk/CHANGES [utf-8] Wed May 21 17:09:19 2008
@@ -6,6 +6,10 @@
 
 Changes with APR-util 1.3.0
 
+  *) All DBD drivers now count rows from 1, which affects PostgreSQL and MySQL
+     drivers in particular. Using row number zero is an error.
+     [Bojan Smojver]
+
   *) Add support for OpenLDAP's ability to support a directory of 
      certificate authorities. [Eric Covener]
 

Modified: apr/apr-util/trunk/test/dbd.c
URL: http://svn.apache.org/viewvc/apr/apr-util/trunk/test/dbd.c?rev=658946&r1=658945&r2=658946&view=diff
==============================================================================
--- apr/apr-util/trunk/test/dbd.c (original)
+++ apr/apr-util/trunk/test/dbd.c Wed May 21 17:09:19 2008
@@ -122,7 +122,7 @@
     for (rv = apr_dbd_get_row(driver, pool, res, &row, -1);
          rv == 0;
          rv = apr_dbd_get_row(driver, pool, res, &row, -1)) {
-        printf("ROW %d:	", i++) ;
+        printf("ROW %d:	", ++i) ;
         for (n = 0; n < apr_dbd_num_cols(driver, res); ++n) {
             entry = apr_dbd_get_entry(driver, row, n);
             if (entry == NULL) {
@@ -295,7 +295,7 @@
     for (rv = apr_dbd_get_row(driver, pool, res, &row, -1);
          rv == 0;
          rv = apr_dbd_get_row(driver, pool, res, &row, -1)) {
-        printf("ROW %d:	", i++) ;
+        printf("ROW %d:	", ++i) ;
         for (n = 0; n < apr_dbd_num_cols(driver, res); ++n) {
             entry = apr_dbd_get_entry(driver, row, n);
             if (entry == NULL) {

Modified: apr/apr-util/trunk/test/testmemcache.c
URL: http://svn.apache.org/viewvc/apr/apr-util/trunk/test/testmemcache.c?rev=658946&r1=658945&r2=658946&view=diff
==============================================================================
--- apr/apr-util/trunk/test/testmemcache.c (original)
+++ apr/apr-util/trunk/test/testmemcache.c Wed May 21 17:09:19 2008
@@ -367,7 +367,7 @@
  apr_status_t rv;
  apr_memcache_t *memcache;
  apr_memcache_server_t *server;
- apr_uint32_t new, next = 2;
+ apr_uint32_t new;
  char *result;
  apr_size_t len;
  apr_uint32_t i;