Return-Path: Delivered-To: apmail-apr-commits-archive@www.apache.org Received: (qmail 18277 invoked from network); 13 Apr 2008 11:11:09 -0000 Received: from hermes.apache.org (HELO mail.apache.org) (140.211.11.2) by minotaur.apache.org with SMTP; 13 Apr 2008 11:11:09 -0000 Received: (qmail 43488 invoked by uid 500); 13 Apr 2008 11:11:08 -0000 Delivered-To: apmail-apr-commits-archive@apr.apache.org Received: (qmail 43433 invoked by uid 500); 13 Apr 2008 11:11:07 -0000 Mailing-List: contact commits-help@apr.apache.org; run by ezmlm Precedence: bulk List-Post: List-Help: List-Unsubscribe: Reply-To: dev@apr.apache.org List-Id: Delivered-To: mailing list commits@apr.apache.org Received: (qmail 43412 invoked by uid 99); 13 Apr 2008 11:11:07 -0000 Received: from nike.apache.org (HELO nike.apache.org) (192.87.106.230) by apache.org (qpsmtpd/0.29) with ESMTP; Sun, 13 Apr 2008 04:11:07 -0700 X-ASF-Spam-Status: No, hits=-0.0 required=10.0 tests=SPF_PASS X-Spam-Check-By: apache.org Received-SPF: pass (nike.apache.org: domain of chip@force-elite.com designates 72.232.80.58 as permitted sender) Received: from [72.232.80.58] (HELO constant.northnitch.com) (72.232.80.58) by apache.org (qpsmtpd/0.29) with ESMTP; Sun, 13 Apr 2008 11:10:16 +0000 Received: from Tornado.local (unknown [213.201.196.162]) by constant.northnitch.com (Postfix) with ESMTP id BD7F072E7; Sun, 13 Apr 2008 06:10:32 -0500 (CDT) Message-ID: <4801EA26.4050203@force-elite.com> Date: Sun, 13 Apr 2008 13:10:30 +0200 From: Paul Querna User-Agent: Thunderbird 2.0.0.12 (Macintosh/20080213) MIME-Version: 1.0 To: dev@apr.apache.org CC: commits@apr.apache.org Subject: Re: svn commit: r647540 - in /apr/apr/trunk: CHANGES include/apr_poll.h poll/unix/epoll.c poll/unix/kqueue.c poll/unix/poll.c poll/unix/port.c poll/unix/select.c test/testpoll.c References: <20080413083112.3124D1A9832@eris.apache.org> In-Reply-To: <20080413083112.3124D1A9832@eris.apache.org> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Virus-Checked: Checked by ClamAV on apache.org mturk@apache.org wrote: > Author: mturk > Date: Sun Apr 13 01:31:03 2008 > New Revision: 647540 .... > Modified: apr/apr/trunk/poll/unix/epoll.c > URL: http://svn.apache.org/viewvc/apr/apr/trunk/poll/unix/epoll.c?rev=647540&r1=647539&r2=647540&view=diff > ============================================================================== > --- apr/apr/trunk/poll/unix/epoll.c (original) > +++ apr/apr/trunk/poll/unix/epoll.c Sun Apr 13 01:31:03 2008 > @@ -68,6 +68,8 @@ > #if APR_HAS_THREADS > /* A thread mutex to protect operations on the rings */ > apr_thread_mutex_t *ring_lock; > + /* Pipe descriptors used for wakeup */ > + apr_file_t *wakeup_pipe[2]; > #endif Why are all of these changes hidden behind APR_HAS_THREADS? I don't think they should be.