Return-Path: Delivered-To: apmail-apr-commits-archive@www.apache.org Received: (qmail 23834 invoked from network); 6 Nov 2007 03:35:40 -0000 Received: from hermes.apache.org (HELO mail.apache.org) (140.211.11.2) by minotaur.apache.org with SMTP; 6 Nov 2007 03:35:40 -0000 Received: (qmail 44678 invoked by uid 500); 6 Nov 2007 03:35:28 -0000 Delivered-To: apmail-apr-commits-archive@apr.apache.org Received: (qmail 44627 invoked by uid 500); 6 Nov 2007 03:35:28 -0000 Mailing-List: contact commits-help@apr.apache.org; run by ezmlm Precedence: bulk List-Post: List-Help: List-Unsubscribe: Reply-To: dev@apr.apache.org List-Id: Delivered-To: mailing list commits@apr.apache.org Received: (qmail 44616 invoked by uid 99); 6 Nov 2007 03:35:28 -0000 Received: from nike.apache.org (HELO nike.apache.org) (192.87.106.230) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 05 Nov 2007 19:35:28 -0800 X-ASF-Spam-Status: No, hits=-100.0 required=10.0 tests=ALL_TRUSTED X-Spam-Check-By: apache.org Received: from [140.211.11.3] (HELO eris.apache.org) (140.211.11.3) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 06 Nov 2007 03:36:07 +0000 Received: by eris.apache.org (Postfix, from userid 65534) id 4AE1F1A9832; Mon, 5 Nov 2007 19:35:17 -0800 (PST) Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Subject: svn commit: r592245 - /apr/apr/trunk/test/testshm.c Date: Tue, 06 Nov 2007 03:35:17 -0000 To: commits@apr.apache.org From: wrowe@apache.org X-Mailer: svnmailer-1.0.8 Message-Id: <20071106033517.4AE1F1A9832@eris.apache.org> X-Virus-Checked: Checked by ClamAV on apache.org Author: wrowe Date: Mon Nov 5 19:35:16 2007 New Revision: 592245 URL: http://svn.apache.org/viewvc?rev=592245&view=rev Log: The test for remove should actually be verifying that we can no longer attach to a now-removed shm resource. Modified: apr/apr/trunk/test/testshm.c Modified: apr/apr/trunk/test/testshm.c URL: http://svn.apache.org/viewvc/apr/apr/trunk/test/testshm.c?rev=592245&r1=592244&r2=592245&view=diff ============================================================================== --- apr/apr/trunk/test/testshm.c (original) +++ apr/apr/trunk/test/testshm.c Mon Nov 5 19:35:16 2007 @@ -232,18 +232,14 @@ } ABTS_PTR_NOTNULL(tc, shm); - rv = apr_shm_create(&shm, SHARED_SIZE, SHARED_FILENAME, p); - APR_ASSERT_SUCCESS(tc, "Error allocating shared memory block", rv); - if (rv != APR_SUCCESS) { - return; - } - ABTS_PTR_NOTNULL(tc, shm); - rv = apr_shm_destroy(shm); APR_ASSERT_SUCCESS(tc, "Error destroying shared memory block", rv); rv = apr_shm_remove(SHARED_FILENAME, p); APR_ASSERT_SUCCESS(tc, "Error removing shared memory block", rv); + + rv = apr_shm_attach(&shm, SHARED_FILENAME, p); + ABTS_TRUE(tc, rv != 0); } #endif