Return-Path: Delivered-To: apmail-apr-commits-archive@www.apache.org Received: (qmail 24990 invoked from network); 13 Nov 2007 04:02:53 -0000 Received: from hermes.apache.org (HELO mail.apache.org) (140.211.11.2) by minotaur.apache.org with SMTP; 13 Nov 2007 04:02:53 -0000 Received: (qmail 65158 invoked by uid 500); 13 Nov 2007 04:02:40 -0000 Delivered-To: apmail-apr-commits-archive@apr.apache.org Received: (qmail 65053 invoked by uid 500); 13 Nov 2007 04:02:39 -0000 Mailing-List: contact commits-help@apr.apache.org; run by ezmlm Precedence: bulk List-Post: List-Help: List-Unsubscribe: Reply-To: dev@apr.apache.org List-Id: Delivered-To: mailing list commits@apr.apache.org Received: (qmail 65032 invoked by uid 99); 13 Nov 2007 04:02:39 -0000 Received: from athena.apache.org (HELO athena.apache.org) (140.211.11.136) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 12 Nov 2007 20:02:39 -0800 X-ASF-Spam-Status: No, hits=-0.0 required=10.0 tests=SPF_HELO_PASS,SPF_PASS X-Spam-Check-By: apache.org Received-SPF: pass (athena.apache.org: domain of bojan@rexursive.com designates 203.171.74.242 as permitted sender) Received: from [203.171.74.242] (HELO beauty.rexursive.com) (203.171.74.242) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 13 Nov 2007 04:02:43 +0000 Received: from [172.27.0.24] (shrek.rexursive.com [172.27.0.24]) by beauty.rexursive.com (Postfix) with ESMTP id 45CBD4038E; Tue, 13 Nov 2007 15:02:21 +1100 (EST) Subject: Re: svn commit: r594037 - in /apr/apr-util/trunk: dbd/apr_dbd.c include/private/apr_dbd_internal.h From: Bojan Smojver To: Davi Arnaut Cc: dev@apr.apache.org, commits@apr.apache.org In-Reply-To: <47390A0F.3040801@apache.org> References: <20071112074642.205D41A9832@eris.apache.org> <47390A0F.3040801@apache.org> Content-Type: text/plain Date: Tue, 13 Nov 2007 15:02:20 +1100 Message-Id: <1194926541.2540.17.camel@shrek.rexursive.com> Mime-Version: 1.0 X-Mailer: Evolution 2.12.1 (2.12.1-3.fc8) Content-Transfer-Encoding: 7bit X-Virus-Checked: Checked by ClamAV on apache.org On Tue, 2007-11-13 at 00:21 -0200, Davi Arnaut wrote: > Missing for the #else case. Fixed in r594422. > It's the functions supposed to be publicly used? If yes, you should > export then properly (apr_dbd.h). If not, it would be better to extend > apr_dbd_t with lock and unlock methods which can back point to private > functions. They are used by the drivers (which are separate .so/.dll files). I haven't seen any problems on Linux, but apparently on Windows they must be APU_DECLAREd or they cannot be seen. They should not go in apr_dbd.h as they have no purpose outside DBD code. -- Bojan