apr-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Bojan Smojver <bo...@rexursive.com>
Subject Re: svn commit: r594037 - in /apr/apr-util/trunk: dbd/apr_dbd.c include/private/apr_dbd_internal.h
Date Tue, 13 Nov 2007 04:02:20 GMT
On Tue, 2007-11-13 at 00:21 -0200, Davi Arnaut wrote:

> Missing for the #else case.

Fixed in r594422.

> It's the functions supposed to be publicly used? If yes, you should
> export then properly (apr_dbd.h). If not, it would be better to extend
> apr_dbd_t with lock and unlock methods which can back point to private
> functions.

They are used by the drivers (which are separate .so/.dll files). I
haven't seen any problems on Linux, but apparently on Windows they must
be APU_DECLAREd or they cannot be seen. They should not go in apr_dbd.h
as they have no purpose outside DBD code.

-- 
Bojan


Mime
View raw message