Return-Path: Delivered-To: apmail-apr-commits-archive@www.apache.org Received: (qmail 90745 invoked from network); 12 Oct 2007 01:50:10 -0000 Received: from hermes.apache.org (HELO mail.apache.org) (140.211.11.2) by minotaur.apache.org with SMTP; 12 Oct 2007 01:50:10 -0000 Received: (qmail 10460 invoked by uid 500); 12 Oct 2007 01:49:58 -0000 Delivered-To: apmail-apr-commits-archive@apr.apache.org Received: (qmail 10410 invoked by uid 500); 12 Oct 2007 01:49:57 -0000 Mailing-List: contact commits-help@apr.apache.org; run by ezmlm Precedence: bulk List-Post: List-Help: List-Unsubscribe: Reply-To: dev@apr.apache.org List-Id: Delivered-To: mailing list commits@apr.apache.org Received: (qmail 10399 invoked by uid 99); 12 Oct 2007 01:49:57 -0000 Received: from athena.apache.org (HELO athena.apache.org) (140.211.11.136) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 11 Oct 2007 18:49:57 -0700 X-ASF-Spam-Status: No, hits=-100.0 required=10.0 tests=ALL_TRUSTED X-Spam-Check-By: apache.org Received: from [140.211.11.3] (HELO eris.apache.org) (140.211.11.3) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 12 Oct 2007 01:50:09 +0000 Received: by eris.apache.org (Postfix, from userid 65534) id 1EAFD1A9832; Thu, 11 Oct 2007 18:49:49 -0700 (PDT) Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Subject: svn commit: r584023 - /apr/apr/trunk/test/testdup.c Date: Fri, 12 Oct 2007 01:49:48 -0000 To: commits@apr.apache.org From: wrowe@apache.org X-Mailer: svnmailer-1.0.8 Message-Id: <20071012014949.1EAFD1A9832@eris.apache.org> X-Virus-Checked: Checked by ClamAV on apache.org Author: wrowe Date: Thu Oct 11 18:49:48 2007 New Revision: 584023 URL: http://svn.apache.org/viewvc?rev=584023&view=rev Log: When we are done with apr_file_t's shall we close them? Modified: apr/apr/trunk/test/testdup.c Modified: apr/apr/trunk/test/testdup.c URL: http://svn.apache.org/viewvc/apr/apr/trunk/test/testdup.c?rev=584023&r1=584022&r2=584023&view=diff ============================================================================== --- apr/apr/trunk/test/testdup.c (original) +++ apr/apr/trunk/test/testdup.c Thu Oct 11 18:49:48 2007 @@ -128,6 +128,8 @@ rv = apr_file_dup2(errfile, saveerr, p); ABTS_INT_EQUAL(tc, APR_SUCCESS, rv); ABTS_PTR_NOTNULL(tc, errfile); + + apr_file_close(saveerr); } static void test_dup2_readwrite(abts_case *tc, void *data) @@ -178,6 +180,8 @@ rv = apr_file_dup2(errfile, saveerr, p); ABTS_INT_EQUAL(tc, APR_SUCCESS, rv); ABTS_PTR_NOTNULL(tc, errfile); + + apr_file_close(saveerr); } abts_suite *testdup(abts_suite *suite)