apr-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "William A. Rowe, Jr." <wr...@rowe-clan.net>
Subject Re: svn commit: r584943 - /apr/apr/trunk/include/arch/os2/apr_arch_inherit.h
Date Mon, 15 Oct 2007 22:19:29 GMT
FYI - would BeOS and Netware folks please review this commit?  It appears to me
that neither actually uses fork-for-exec, and both certainly fail to call the
apr_pool_cleanup_for_exec() mandatory hook if they do use that approach.

Bill

wrowe@apache.org wrote:
> Author: wrowe
> Date: Mon Oct 15 15:07:32 2007
> New Revision: 584943
> 
> URL: http://svn.apache.org/viewvc?rev=584943&view=rev
> Log:
> OS2 fails to fork-for-exec, and therefore doesn't use the
> apr_pool_cleanup_for_exec hook, which means it's leaking
> like a sieve.  This alternate implementation of the function
> is sub-optimal because parallel threads can be setting up
> handles to be inherited, and this just isn't healthy.
> 
> The best fix is to create all handles uninherited, and only
> toggle the std streams to be inherited in apr_proc_create().
> 
> I'm happy to work with any OS2 folk to make that happen.



Mime
View raw message