apr-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From bnicho...@apache.org
Subject svn commit: r585260 - /apr/apr/trunk/threadproc/netware/proc.c
Date Tue, 16 Oct 2007 20:43:04 GMT
Author: bnicholes
Date: Tue Oct 16 13:43:03 2007
New Revision: 585260

URL: http://svn.apache.org/viewvc?rev=585260&view=rev
Log:
Fix up a few netware'isms and missing brackets left over from the refactoring.

Modified:
    apr/apr/trunk/threadproc/netware/proc.c

Modified: apr/apr/trunk/threadproc/netware/proc.c
URL: http://svn.apache.org/viewvc/apr/apr/trunk/threadproc/netware/proc.c?rev=585260&r1=585259&r2=585260&view=diff
==============================================================================
--- apr/apr/trunk/threadproc/netware/proc.c (original)
+++ apr/apr/trunk/threadproc/netware/proc.c Tue Oct 16 13:43:03 2007
@@ -110,7 +110,7 @@
 APR_DECLARE(apr_status_t) apr_procattr_child_in_set(apr_procattr_t *attr, apr_file_t *child_in,
                                    apr_file_t *parent_in)
 {
-    apr_status_t rv;
+    apr_status_t rv = APR_SUCCESS;
 
     if (attr->child_in == NULL && attr->parent_in == NULL
             && child_in == NULL && parent_in == NULL)
@@ -127,9 +127,11 @@
                     == APR_SUCCESS)
                 rv = apr_file_inherit_set(attr->child_in);
         }
+    }
 
     if (parent_in != NULL && rv == APR_SUCCESS) {
         rv = apr_file_dup(&attr->parent_in, parent_in, attr->pool);
+    }
 
     return rv;
 }
@@ -138,7 +140,7 @@
 APR_DECLARE(apr_status_t) apr_procattr_child_out_set(apr_procattr_t *attr, apr_file_t *child_out,
                                                      apr_file_t *parent_out)
 {
-    apr_status_t rv;
+    apr_status_t rv = APR_SUCCESS;
 
     if (attr->child_out == NULL && attr->parent_out == NULL
            && child_out == NULL && parent_out == NULL)
@@ -159,6 +161,7 @@
   
     if (parent_out != NULL && rv == APR_SUCCESS) {
         rv = apr_file_dup(&attr->parent_out, parent_out, attr->pool);
+    }
 
     return rv;
 }
@@ -167,7 +170,7 @@
 APR_DECLARE(apr_status_t) apr_procattr_child_err_set(apr_procattr_t *attr, apr_file_t *child_err,
                                                      apr_file_t *parent_err)
 {
-    apr_status_t rv;
+    apr_status_t rv = APR_SUCCESS;
 
     if (attr->child_err == NULL && attr->parent_err == NULL
            && child_err == NULL && parent_err == NULL)
@@ -188,6 +191,7 @@
   
     if (parent_err != NULL && rv == APR_SUCCESS) {
         rv = apr_file_dup(&attr->parent_err, parent_err, attr->pool);
+    }
 
     return rv;
 }
@@ -315,15 +319,15 @@
     wire.infd  = attr->child_in  
                ? (attr->child_in->filedes != -1 ? attr->child_in->filedes 
                                                 : FD_UNUSED)
-               : FILENO_STDIN;
+               : fileno(stdin);
     wire.outfd  = attr->child_out
                 ? (attr->child_out->filedes != -1 ? attr->child_out->filedes

                                                   : FD_UNUSED)
-                : FILENO_STDOUT;
+                : fileno(stdout);
     wire.errfd  = attr->child_err
                 ? (attr->child_err->filedes != -1 ? attr->child_err->filedes

                                                   : FD_UNUSED)
-                : FILENO_STDERR;
+                : fileno(stderr);
 
     newproc->in = attr->parent_in;
     newproc->out = attr->parent_out;



Mime
View raw message