apr-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From bo...@apache.org
Subject svn commit: r537001 - /apr/apr-util/trunk/dbd/apr_dbd_oracle.c
Date Thu, 10 May 2007 21:35:04 GMT
Author: bojan
Date: Thu May 10 14:35:04 2007
New Revision: 537001

URL: http://svn.apache.org/viewvc?view=rev&rev=537001
Log:
Apply patch from bug #41250, by Chris Darroch
Extra pool layer is not required

Modified:
    apr/apr-util/trunk/dbd/apr_dbd_oracle.c

Modified: apr/apr-util/trunk/dbd/apr_dbd_oracle.c
URL: http://svn.apache.org/viewvc/apr/apr-util/trunk/dbd/apr_dbd_oracle.c?view=diff&rev=537001&r1=537000&r2=537001
==============================================================================
--- apr/apr-util/trunk/dbd/apr_dbd_oracle.c (original)
+++ apr/apr-util/trunk/dbd/apr_dbd_oracle.c Thu May 10 14:35:04 2007
@@ -458,15 +458,9 @@
     size_t vlen;
     static const char *const delims = " \r\n\t;|,";
 
+    ret->pool = pool;
     ret->long_size = DEFAULT_LONG_SIZE;
 
-    /* Use our own pool, to avoid possible race conditions
-     * on pool ops
-     */
-    if (apr_pool_create(&ret->pool, pool) != APR_SUCCESS) {
-        return NULL;
-    }
-
     /* snitch parsing from the MySQL driver */
     for (ptr = strchr(params, '='); ptr; ptr = strchr(ptr, '=')) {
         for (key = ptr-1; isspace(*key); --key);
@@ -2176,7 +2170,6 @@
     default:
         break;
     }
-    apr_pool_destroy(handle->pool);
     return APR_SUCCESS;
 }
 



Mime
View raw message