Mailing-List: contact commits-help@apr.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@apr.apache.org
Received-SPF: pass (herse.apache.org: domain of minfrin@sharp.fm designates
 64.49.220.200 as permitted sender)
Message-ID: <45861.196.8.104.31.1175099228.squirrel@www.sharp.fm>
In-Reply-To: <20070328161554.169761A983A@eris.apache.org>
References: <20070328161554.169761A983A@eris.apache.org>
Date: Wed, 28 Mar 2007 18:27:08 +0200 (SAST)
Subject: Re: svn commit: r523390 - /apr/apr-util/trunk/ssl/apr_ssl_openssl.c
From: "Graham Leggett" <minfrin@sharp.fm>
To: dev@apr.apache.org
Cc: commits@apr.apache.org
User-Agent: SquirrelMail/1.4.8-4.el4
MIME-Version: 1.0
Content-Type: text/plain;charset=iso-8859-1
Content-Transfer-Encoding: 8bit
Importance: Normal

On Wed, March 28, 2007 6:15 pm, dreid@apache.org wrote:

> We need to add an error code for "there was an openssl error"
> to allow us to direct the user to call a function to determine
> what was wrong.
>
> Highlighted by Joe Orton

By way of example, the apr_ldap code tries to solve this problem by
returning a structure containing the original LDAP error code, the LDAP
toolkit's "error string" corresponding to that code, as well as a string
that tries to explain what APR was trying to do at the time of the error
(often the LDAP error is a red herring or too vague). Most of this info is
very cheap to produce.

The rationale behind it was to make it very easy for the (potentially
lazy) APR-using coder to expose useful information to the end user when
problems occurred.

What may be a useful exercise is to combine this into a generic "APR error
structure", so that the LDAP stuff, the SQL stuff, and the SSL stuff can
report errors in the same fashion.

Regards,
Graham
--