Return-Path: Delivered-To: apmail-apr-commits-archive@www.apache.org Received: (qmail 72091 invoked from network); 28 Feb 2007 18:32:14 -0000 Received: from hermes.apache.org (HELO mail.apache.org) (140.211.11.2) by minotaur.apache.org with SMTP; 28 Feb 2007 18:32:14 -0000 Received: (qmail 16939 invoked by uid 500); 28 Feb 2007 18:32:22 -0000 Delivered-To: apmail-apr-commits-archive@apr.apache.org Received: (qmail 16912 invoked by uid 500); 28 Feb 2007 18:32:22 -0000 Mailing-List: contact commits-help@apr.apache.org; run by ezmlm Precedence: bulk List-Post: List-Help: List-Unsubscribe: Reply-To: dev@apr.apache.org List-Id: Delivered-To: mailing list commits@apr.apache.org Received: (qmail 16885 invoked by uid 99); 28 Feb 2007 18:32:22 -0000 Received: from herse.apache.org (HELO herse.apache.org) (140.211.11.133) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 28 Feb 2007 10:32:22 -0800 X-ASF-Spam-Status: No, hits=-0.0 required=10.0 tests=SPF_PASS X-Spam-Check-By: apache.org Received-SPF: pass (herse.apache.org: domain of justin.erenkrantz@gmail.com designates 64.233.162.229 as permitted sender) Received: from [64.233.162.229] (HELO nz-out-0506.google.com) (64.233.162.229) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 28 Feb 2007 10:32:11 -0800 Received: by nz-out-0506.google.com with SMTP id r28so232948nza for ; Wed, 28 Feb 2007 10:31:50 -0800 (PST) DKIM-Signature: a=rsa-sha1; c=relaxed/relaxed; d=gmail.com; s=beta; h=domainkey-signature:received:received:message-id:date:from:sender:to:subject:cc:in-reply-to:mime-version:content-type:content-transfer-encoding:content-disposition:references:x-google-sender-auth; b=jHytSawh8IX6velW6BbvOpTgPYCxMRRqlzi0AT4Z7L6mpjYcMV0jM1tIp7SbD0rnzlFHijZvWIuYzwlXiU9BgUXxVNNzgq/sQLTgLt0tgWEeggoaS5VYJLc2aE+OvQAUaODZpJdTSO/VIaMzCTylJy9sLPvW9mUNWSCh0xDUjFE= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=beta; h=received:message-id:date:from:sender:to:subject:cc:in-reply-to:mime-version:content-type:content-transfer-encoding:content-disposition:references:x-google-sender-auth; b=qheQIwD/ThzPsnTnwFJQpQ37V3CdtSCiFqC72zJNURhVV4Gc7+UyEpeLlYhH3oRE61curOZspc6jmueZ3Dckzmi6JXGe2CUBGQCF3QUcLzqwGvy57ECp2qShLuqOtxVPp0AyjA2rss+QB1apucUOQJEkeXVyXd3n6uLxBQLBQhU= Received: by 10.114.168.1 with SMTP id q1mr81152wae.1172687488831; Wed, 28 Feb 2007 10:31:28 -0800 (PST) Received: by 10.114.192.2 with HTTP; Wed, 28 Feb 2007 10:31:28 -0800 (PST) Message-ID: <5c902b9e0702281031i78e82baey382399a8c856d721@mail.gmail.com> Date: Wed, 28 Feb 2007 10:31:28 -0800 From: "Justin Erenkrantz" Sender: justin.erenkrantz@gmail.com To: dev@apr.apache.org Subject: Re: svn commit: r512882 - in /apr/apr/trunk: file_io/os2/readwrite.c file_io/unix/readwrite.c test/testfile.c Cc: commits@apr.apache.org In-Reply-To: <20070228180538.A0CFA1A981C@eris.apache.org> MIME-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Content-Disposition: inline References: <20070228180538.A0CFA1A981C@eris.apache.org> X-Google-Sender-Auth: e54314015d5648da X-Virus-Checked: Checked by ClamAV on apache.org On 2/28/07, pquerna@apache.org wrote: > Author: pquerna > Date: Wed Feb 28 10:05:37 2007 > New Revision: 512882 > > URL: http://svn.apache.org/viewvc?view=rev&rev=512882 > Log: > Fix apr_file_writev when buffering is enabled by forcing a flush, rather than writing underneath the write buffer. How about conditionally flushing if we have buffering enabled? -- justin