apr-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From pque...@apache.org
Subject svn commit: r422924 - /apr/apr/trunk/file_io/win32/filepath.c
Date Tue, 18 Jul 2006 00:08:59 GMT
Author: pquerna
Date: Mon Jul 17 17:08:58 2006
New Revision: 422924

URL: http://svn.apache.org/viewvc?rev=422924&view=rev
Log:
Revert r422157, attempting to fix case sensitivity testnames failures, because it has been
vetoed:
http://mail-archives.apache.org/mod_mbox/apr-dev/200607.mbox/%3c44B9A74A.7020906@rowe-clan.net%3e

Modified:
    apr/apr/trunk/file_io/win32/filepath.c

Modified: apr/apr/trunk/file_io/win32/filepath.c
URL: http://svn.apache.org/viewvc/apr/apr/trunk/file_io/win32/filepath.c?rev=422924&r1=422923&r2=422924&view=diff
==============================================================================
--- apr/apr/trunk/file_io/win32/filepath.c (original)
+++ apr/apr/trunk/file_io/win32/filepath.c Mon Jul 17 17:08:58 2006
@@ -283,6 +283,10 @@
     {
         apr_status_t rv;
         /* Validate that D:\ drive exists, test must be rooted
+         * Note that posix/win32 insists a drive letter is upper case,
+         * so who are we to argue with a 'feature'.
+         * It is a safe fold, since only A-Z is legal, and has no
+         * side effects of legal mis-mapped non-us-ascii codes.
          */
         newpath = apr_palloc(p, 4);
         newpath[0] = testpath[0];
@@ -290,6 +294,7 @@
         newpath[2] = seperator[0];
         newpath[3] = '\0';
         if (flags & APR_FILEPATH_TRUENAME) {
+            newpath[0] = apr_toupper(newpath[0]);
             rv = filepath_root_test(newpath, p);
             if (rv)
                 return rv;



Mime
View raw message