Patch Format

Patch Format -

We prefer that patches be submitted in unified diff format:

We request that patches be submitted in unified diff format:

diff -u file-old.c file.c

but that isn't available on all platforms. If your platform doesn't -support unified diffs, please use a context diff instead:

or if working with an svn checkout:

+ +

svn diff file.c

+ +

where file.c is the file affected. (Older versions of diff +may require -u3 to display lines of context, but the current version of GNU +diff has deprecated the trailing number for -u and presumes three lines, +use -U# syntax if you wish to provide more lines of context.)

+ +

You can obtain the most sophisticated diff utility from the GNU diffutils +project:

+ +

http://www.gnu.org/software/diffutils/diffutils.html

+ +

and Windows users can obtain a native port of diff and other useful utilites +from:

+ +

http://unxutils.sourceforge.net/

+ +

If you cannot produce a unified diff, then at least please submit +a context diff:

diff -C3 file-old.c file.c

where file.c is the file affected. We should be able to feed -the patch directly into the "patch" program and have it update the file or set -of files. The -C3 is very important - line numbers can change on -a daily basis in some code files, so having context is crucial to knowing where -it all really goes.

We should be able to feed the patch directly into the "patch" program and +have it update the file or set of files. The -u or +-C3 is critical; the existing code changes regularly, so having +context is crucial to understanding your patch and knowing where it all really +goes. Patches without filenames, line numbers and surrounding context become +impossible to consider as time goes on.

Submitting Your Patch -

If you are a subscriber to dev@apr.apache.org, you can simply post +

The best place to submit your patch is an attachment to a bug report:

+ +

http://issues.apache.org/bugzilla/

+ +

Be certain to 1) research your patch, ensure that it isn't already in an +existing bug report, and that similiar code hasn't already been committed to +the working development trunk:

+ +

http://svn.apache.org/repos/asf/apr/apr/trunk

http://svn.apache.org/repos/asf/apr/apr-util/trunk

http://svn.apache.org/repos/asf/apr/apr-iconv/trunk

+ +

Ensure your patch is attached as a text/ type file, and try retrieving it +yourself after you add it, to ensure that others can, too. Do not submit links +to other locations for your patch (or anyone else's patch!), as they will only +be considered when submitted directly to the ASF by the original author.

+ +

If you are a subscriber to dev@apr.apache.org, you can also post your patch there, with the string "[PATCH]" prefixing your subject line, so everyone knows it's a patch. However, it's not guaranteed that your Patch will find an advocate within the developers' group; if we're too busy working on