apr-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Joe Orton <jor...@redhat.com>
Subject Re: svn commit: r376501 - /apr/apr/branches/1.2.x/test/testuser.c
Date Fri, 10 Feb 2006 08:14:03 GMT
On Fri, Feb 10, 2006 at 12:10:01AM -0000, William Rowe wrote:
> Author: wrowe
> Date: Thu Feb  9 16:09:59 2006
> New Revision: 376501
> 
> URL: http://svn.apache.org/viewcvs?rev=376501&view=rev
> Log:
> 
>   This test can't be portably implemented until we define a symbol
>   to declare that apr_[ug]id_t is intregal, as opposed to the current
>   opaque definition on Win32.
> 
> Backports 376409

-1, please do not arbitrarily disable tests on all platforms just 
because one platform is "special".  Use #ifndef WIN32, as I said *twice* 
already.

> --- apr/apr/branches/1.2.x/test/testuser.c (original)
> +++ apr/apr/branches/1.2.x/test/testuser.c Thu Feb  9 16:09:59 2006
> @@ -94,6 +94,8 @@
>                         apr_gid_compare(gid, retreived_gid));
>  }
>  
> +#ifdef APR_UID_GID_NUMERIC
> +
>  static void fail_userinfo(abts_case *tc, void *data)


Mime
View raw message