apr-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From roo...@apache.org
Subject svn commit: r372619 - in /apr/apr/branches/0.9.x: CHANGES threadproc/win32/proc.c
Date Thu, 26 Jan 2006 21:47:50 GMT
Author: rooneg
Date: Thu Jan 26 13:47:48 2006
New Revision: 372619

URL: http://svn.apache.org/viewcvs?rev=372619&view=rev
Log:
Merge r355792 to 0.9.x.

Original log message:

Fix passing "" as an argument to a new program on windows.

* threadproc/win32/proc.c
  (apr_proc_create): Pass empty strings into CreateProcess instead of
   filtering them out.

* CHANGES: Note change.

Submitted by: Philip Martin <philip codematters.co.uk>
Reviewed by: wrowe, rooneg

Modified:
    apr/apr/branches/0.9.x/CHANGES
    apr/apr/branches/0.9.x/threadproc/win32/proc.c

Modified: apr/apr/branches/0.9.x/CHANGES
URL: http://svn.apache.org/viewcvs/apr/apr/branches/0.9.x/CHANGES?rev=372619&r1=372618&r2=372619&view=diff
==============================================================================
--- apr/apr/branches/0.9.x/CHANGES (original)
+++ apr/apr/branches/0.9.x/CHANGES Thu Jan 26 13:47:48 2006
@@ -13,6 +13,10 @@
      used in such a case.
      [Garrett Rooney]
 
+  *) Fix passing "" as an argument to the program started by apr_proc_create
+     on Win32.
+     [Philip Martin <philip codematters.co.uk>
+
   *) Fix warning when compiling on FreeBSD by correcting the type of
      the final argument passed to sysctlbyname. [Garrett Rooney]
 

Modified: apr/apr/branches/0.9.x/threadproc/win32/proc.c
URL: http://svn.apache.org/viewcvs/apr/apr/branches/0.9.x/threadproc/win32/proc.c?rev=372619&r1=372618&r2=372619&view=diff
==============================================================================
--- apr/apr/branches/0.9.x/threadproc/win32/proc.c (original)
+++ apr/apr/branches/0.9.x/threadproc/win32/proc.c Thu Jan 26 13:47:48 2006
@@ -347,7 +347,7 @@
     /* Handle the args, seperate from argv0 */
     cmdline = "";
     for (i = 1; args && args[i]; ++i) {
-        if (has_space(args[i])) {
+        if (has_space(args[i]) || !args[i][0]) {
             cmdline = apr_pstrcat(pool, cmdline, " \"", args[i], "\"", NULL);
         }
         else {



Mime
View raw message