apr-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From roo...@apache.org
Subject svn commit: r355792 - in /apr/apr/trunk: CHANGES threadproc/win32/proc.c
Date Sat, 10 Dec 2005 22:29:41 GMT
Author: rooneg
Date: Sat Dec 10 14:29:40 2005
New Revision: 355792

URL: http://svn.apache.org/viewcvs?rev=355792&view=rev
Log:
Fix passing "" as an argument to a new program on windows.

* threadproc/win32/proc.c
  (apr_proc_create): Pass empty strings into CreateProcess instead of
   filtering them out.

* CHANGES: Note change.

Submitted by: Philip Martin <philip codematters.co.uk>
Reviewed by: wrowe, rooneg

Modified:
    apr/apr/trunk/CHANGES
    apr/apr/trunk/threadproc/win32/proc.c

Modified: apr/apr/trunk/CHANGES
URL: http://svn.apache.org/viewcvs/apr/apr/trunk/CHANGES?rev=355792&r1=355791&r2=355792&view=diff
==============================================================================
--- apr/apr/trunk/CHANGES (original)
+++ apr/apr/trunk/CHANGES Sat Dec 10 14:29:40 2005
@@ -7,6 +7,10 @@
   *) Fix EOF handling for unbuffered reads on win32.
      [Konstantin Sharenkov <Konstantin.Sharenkov enterra-inc.com>]
 
+  *) Fix passing "" as an argument to the program started by apr_proc_create
+     on Win32.
+     [Philip Martin <philip codematters.co.uk>
+
 Changes for APR 1.3.0
 
   *) Bugfix for apr_pollset_poll() on systems that implement pollsets

Modified: apr/apr/trunk/threadproc/win32/proc.c
URL: http://svn.apache.org/viewcvs/apr/apr/trunk/threadproc/win32/proc.c?rev=355792&r1=355791&r2=355792&view=diff
==============================================================================
--- apr/apr/trunk/threadproc/win32/proc.c (original)
+++ apr/apr/trunk/threadproc/win32/proc.c Sat Dec 10 14:29:40 2005
@@ -460,7 +460,7 @@
     /* Handle the args, seperate from argv0 */
     cmdline = "";
     for (i = 1; args && args[i]; ++i) {
-        if (has_space(args[i])) {
+        if (has_space(args[i]) || !args[i][0]) {
             cmdline = apr_pstrcat(pool, cmdline, " \"", args[i], "\"", NULL);
         }
         else {



Mime
View raw message