apr-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "William A. Rowe, Jr." <wr...@rowe-clan.net>
Subject Re: svn commit: r329089 - in /apr/apr-util/trunk: build.conf include/apr_memcache.h memcache/ memcache/apr_memcache.c
Date Fri, 28 Oct 2005 06:08:52 GMT
pquerna@apache.org wrote:
> Author: pquerna
> Date: Thu Oct 27 21:23:01 2005
> New Revision: 329089
> 
> URL: http://svn.apache.org/viewcvs?rev=329089&view=rev
> Log:
> Import apr_memcache trunk to APR-Util.
> 
> Still TODO:
> - Move CRC32 to a separate public function/API.
> - Create a multi-get interface.
> - Make locking and connection pooling optional.

For the moment, -1, please revert and begin an apr-memcache sandbox because...

  * it makes trunk/ unstable, preventing us from moving to 1.3

  * this seems entirely too specialized (in other words, useless code bloat)
    All of the concepts here -are- useful, but not in this aggregation.

  * if we trust that this code is incomplete (my objections and your TODO)
    then we have to partition it off for a while, till it's fleshed out.
    With ABI/API stability a prime concern, dropping in an interface that
    the group will suggest improvements and code style corrections for, is
    a bad thing in a live 1.x release at this stage of it's development.

I.O.W. I like many of the things we could accomplish here, but single-purpose
code doesn't belong in apr-util.  Let's flesh out these ideas here on list.

Bill

Mime
View raw message