apr-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "William A. Rowe, Jr." <wr...@rowe-clan.net>
Subject Re: svn commit: r164100 - /apr/apr/trunk/include/apr.hw
Date Thu, 21 Apr 2005 19:33:40 GMT
The more I consider this proposition, the more inappropriate it
appears.  We are modifying not the APR environment, this patch
modifies the native API.

APR wasn't designed to change the native environment, but provide
a rich crossplatform alternative.

I'd prefer this is backed out.  You won't break anything in your
app by modifying the environment (e.g. your sources include the
#define FD_SETSIZE 1024) followed by including APR.

But you are asking APR to do something on Windows that we would
not do on any other platform.

Sorry that it had not occurred to me that the answer to your
original question was independent of the apr_poll discussion.

If you have need for changing this for APR's use, our 
include/arch/win32/ internals are the appropriate place.

Bill


>Author: mturk
>Date: Thu Apr 21 11:59:25 2005
>New Revision: 164100
>
>URL: http://svn.apache.org/viewcvs?rev=164100&view=rev
>Log:
>Set FD_SETSIZE to 1024 like POSIX does.
>This does not mean that more then 64 sockets
>will be allowed for select. Custom network protocol
>stack might dissreagard this setting.
>
>Modified:
>    apr/apr/trunk/include/apr.hw
>
>Modified: apr/apr/trunk/include/apr.hw
>URL: http://svn.apache.org/viewcvs/apr/apr/trunk/include/apr.hw?rev=164100&r1=164099&r2=164100&view=diff
>==============================================================================
>--- apr/apr/trunk/include/apr.hw (original)
>+++ apr/apr/trunk/include/apr.hw Thu Apr 21 11:59:25 2005
>@@ -86,6 +86,8 @@
>  */
> #define SW_HIDE             0
> #ifndef _WIN32_WCE
>+/* POSIX defines 1024 for the FD_SETSIZE */
>+#define FD_SETSIZE 1024
> #include <winsock2.h>
> #include <mswsock.h>
> #include <ws2tcpip.h>



Mime
View raw message