Mailing-List: contact commits-help@apr.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@apr.apache.org
Received-SPF: pass (hermes.apache.org: local policy)
Message-ID: <62272.196.8.104.27.1106321687.squirrel@www.sharp.fm>
In-Reply-To: <20050121145850.GB12376@redhat.com>
References: <20050121145354.74850.qmail@minotaur.apache.org>
    <20050121145850.GB12376@redhat.com>
Date: Fri, 21 Jan 2005 17:34:47 +0200 (SAST)
Subject: Re: svn commit: r125933 - /apr/apr-util/trunk/build/apu-conf.m4
     /apr/apr-util/trunk/include/apr_ldap.h.in
     /apr/apr-util/trunk/include/apr_ldap.hnw
     /apr/apr-util/trunk/include/apr_ldap.hw
     /apr/apr-util/trunk/ldap/apr_ldap_option.c
From: "Graham Leggett" <minfrin@sharp.fm>
To: "Joe Orton" <jorton@redhat.com>
Cc: dev@apr.apache.org, commits@apr.apache.org
User-Agent: SquirrelMail/1.4.3a-7.EL3
MIME-Version: 1.0
Content-Type: text/plain;charset=iso-8859-1
Content-Transfer-Encoding: 8bit
Importance: Normal

Joe Orton said:

> APR_HAS_LDAPSSL_INSTALL_ROUTINES does not look like it needs to be
> exported via apr_ldap.h, so it should just be flagged in apu_config.h
> using:
>
>  AC_DEFINE(HAVE_LDAPSSL_INSTALL_ROUTINES, 1, [Defined if...])
>
> ...nothing that can be kept private should be exported in the API,
> especially not in a 1.x.y branch.

This would be true if it was assumed that the end user would never want to
use the LDAP native functions themselves, and would always want to use
APR's portability functions - this is a separate debate. But if this was
true, then all the ldap*ssl*() functions need to be removed from this
macro, not just ldapssl_install_routines(), and that can only happen in
APR v2.0 as it's an API change.

An added complication is that the test for the presence of
ldapssl_install_routines() and friends can only happen after a lengthy and
non trivial search for the "right" combination of LDAP libraries on each
platform. As long as this isn't a problem, AC_DEFINE can be used.

Regards,
Graham
--