apr-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From jor...@apache.org
Subject cvs commit: apr/shmem/unix shm.c
Date Thu, 27 May 2004 16:00:06 GMT
jorton      2004/05/27 09:00:06

  Modified:    shmem/unix shm.c
  Log:
  * shmem/unix/shm.c (apr_shm_create): Answer some FIXMEs: wrong, yes, no.
  
  Revision  Changes    Path
  1.26      +1 -4      apr/shmem/unix/shm.c
  
  Index: shm.c
  ===================================================================
  RCS file: /home/cvs/apr/shmem/unix/shm.c,v
  retrieving revision 1.25
  retrieving revision 1.26
  diff -d -u -r1.25 -r1.26
  --- shm.c	27 May 2004 15:52:46 -0000	1.25
  +++ shm.c	27 May 2004 16:00:05 -0000	1.26
  @@ -254,8 +254,7 @@
           }
   #endif /* APR_USE_SHMEM_MMAP_TMP */
   #if APR_USE_SHMEM_MMAP_SHM
  -        /* FIXME: Is APR_OS_DEFAULT sufficient? */
  -        tmpfd = shm_open(filename, O_RDWR | O_CREAT | O_EXCL, APR_OS_DEFAULT);
  +        tmpfd = shm_open(filename, O_RDWR | O_CREAT | O_EXCL, 0644);
           if (tmpfd == -1) {
               return errno;
           }
  @@ -277,7 +276,6 @@
   
           /* FIXME: check for errors */
   
  -        /* FIXME: Is it ok to close this file when using shm_open?? */
           status = apr_file_close(file);
           if (status != APR_SUCCESS) {
               return status;
  @@ -462,7 +460,6 @@
   
           new_m = apr_palloc(pool, sizeof(apr_shm_t));
   
  -        /* FIXME: does APR_OS_DEFAULT matter for reading? */
           status = apr_file_open(&file, filename, 
                                  APR_READ, APR_OS_DEFAULT, pool);
           if (status != APR_SUCCESS) {
  
  
  

Mime
View raw message