apr-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From jerenkra...@apache.org
Subject cvs commit: apr/network_io/win32 sockopt.c
Date Sat, 03 Apr 2004 17:15:52 GMT
jerenkrantz    2004/04/03 09:15:52

  Modified:    .        CHANGES
               network_io/unix sockopt.c
               network_io/win32 sockopt.c
  Log:
  Even if we do not check the value of APR_IPV6_V6ONLY before setting, we still
  must set the option cache if we're setting APR_IPV6_V6ONLY.  Otherwise,
  later apr_socket_opt_get calls will fail.
  
  This fixes Listen directives on IPv6 machines where IPV6_V6ONLY may be
  enabled (i.e. FreeBSD 5.x, OpenBSD, NetBSD) where it would not properly
  bind to the IPv4 socket.
  
  Revision  Changes    Path
  1.456     +4 -0      apr/CHANGES
  
  Index: CHANGES
  ===================================================================
  RCS file: /home/cvs/apr/CHANGES,v
  retrieving revision 1.455
  retrieving revision 1.456
  diff -u -u -r1.455 -r1.456
  --- CHANGES	27 Mar 2004 13:11:17 -0000	1.455
  +++ CHANGES	3 Apr 2004 17:15:52 -0000	1.456
  @@ -120,6 +120,10 @@
   
   Changes with APR 0.9.5
   
  +  *) Fix apr_socket_opt_set with APR_IPV6_V6ONLY flag.  Fixes httpd
  +     Listen IPv6 socket behavior on FreeBSD 5.x, OpenBSD, NetBSD.
  +     [Justin Erenkrantz]
  +
     *) Fix apr_time_exp_get() for dates in 2038.  
        [Philip Martin <philip codematters.co.uk>]
   
  
  
  
  1.79      +2 -1      apr/network_io/unix/sockopt.c
  
  Index: sockopt.c
  ===================================================================
  RCS file: /home/cvs/apr/network_io/unix/sockopt.c,v
  retrieving revision 1.78
  retrieving revision 1.79
  diff -u -u -r1.78 -r1.79
  --- sockopt.c	27 Feb 2004 15:06:26 -0000	1.78
  +++ sockopt.c	3 Apr 2004 17:15:52 -0000	1.79
  @@ -283,13 +283,14 @@
       case APR_IPV6_V6ONLY:
   #if APR_HAVE_IPV6 && defined(IPV6_V6ONLY)
           /* we don't know the initial setting of this option,
  -         * so don't check/set sock->options since that optimization
  +         * so don't check sock->options since that optimization
            * won't work
            */
           if (setsockopt(sock->socketdes, IPPROTO_IPV6, IPV6_V6ONLY,
                          (void *)&on, sizeof(int)) == -1) {
               return errno;
           }
  +        apr_set_option(sock, APR_IPV6_V6ONLY, on);
   #else
           return APR_ENOTIMPL;
   #endif
  
  
  
  1.58      +2 -1      apr/network_io/win32/sockopt.c
  
  Index: sockopt.c
  ===================================================================
  RCS file: /home/cvs/apr/network_io/win32/sockopt.c,v
  retrieving revision 1.57
  retrieving revision 1.58
  diff -u -u -r1.57 -r1.58
  --- sockopt.c	13 Feb 2004 09:38:33 -0000	1.57
  +++ sockopt.c	3 Apr 2004 17:15:52 -0000	1.58
  @@ -169,13 +169,14 @@
       case APR_IPV6_V6ONLY:
   #if APR_HAVE_IPV6 && defined(IPV6_V6ONLY)
           /* we don't know the initial setting of this option,
  -         * so don't check/set sock->options since that optimization
  +         * so don't check sock->options since that optimization
            * won't work
            */
           if (setsockopt(sock->socketdes, IPPROTO_IPV6, IPV6_V6ONLY,
                          (void *)&on, sizeof(int)) == -1) {
               return apr_get_netos_error();
           }
  +        apr_set_option(sock, APR_IPV6_V6ONLY, on);
   #else
           return APR_ENOTIMPL;
   #endif
  
  
  

Mime
View raw message