Return-Path: Delivered-To: apmail-apr-cvs-archive@www.apache.org Received: (qmail 13547 invoked from network); 28 Oct 2003 11:31:35 -0000 Received: from daedalus.apache.org (HELO mail.apache.org) (208.185.179.12) by minotaur-2.apache.org with SMTP; 28 Oct 2003 11:31:35 -0000 Received: (qmail 21456 invoked by uid 500); 28 Oct 2003 11:31:35 -0000 Delivered-To: apmail-apr-cvs-archive@apr.apache.org Received: (qmail 21408 invoked by uid 500); 28 Oct 2003 11:31:34 -0000 Mailing-List: contact cvs-help@apr.apache.org; run by ezmlm Precedence: bulk List-Post: List-Help: List-Unsubscribe: List-Subscribe: Reply-To: dev@apr.apache.org Delivered-To: mailing list cvs@apr.apache.org Received: (qmail 21395 invoked from network); 28 Oct 2003 11:31:34 -0000 Date: 28 Oct 2003 11:31:34 -0000 Message-ID: <20031028113134.13532.qmail@minotaur.apache.org> From: gstein@apache.org To: apr-cvs@apache.org Subject: cvs commit: apr/poll/unix poll.c X-Spam-Rating: daedalus.apache.org 1.6.2 0/1000/N X-Spam-Rating: minotaur-2.apache.org 1.6.2 0/1000/N gstein 2003/10/28 03:31:34 Modified: poll/unix poll.c Log: Avoid the temptation to remember the pool. That can lead to disaster. * poll/unix/poll.c: (struct apr_pollset_t): remove the 'pool' member (apr_pollset_create): do not store the poll into the new struct Revision Changes Path 1.39 +2 -2 apr/poll/unix/poll.c Index: poll.c =================================================================== RCS file: /home/cvs/apr/poll/unix/poll.c,v retrieving revision 1.38 retrieving revision 1.39 diff -u -r1.38 -r1.39 --- poll.c 7 Jan 2003 00:52:56 -0000 1.38 +++ poll.c 28 Oct 2003 11:31:34 -0000 1.39 @@ -329,7 +329,7 @@ #endif apr_pollfd_t *query_set; apr_pollfd_t *result_set; - apr_pool_t *pool; + #ifdef NETWARE int set_type; #endif @@ -362,7 +362,7 @@ #endif (*pollset)->query_set = apr_palloc(p, size * sizeof(apr_pollfd_t)); (*pollset)->result_set = apr_palloc(p, size * sizeof(apr_pollfd_t)); - (*pollset)->pool = p; + return APR_SUCCESS; }