Mailing-List: contact cvs-help@apr.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@apr.apache.org
Date: 15 Feb 2003 18:09:30 -0000
Message-ID: <20030215180930.47312.qmail@icarus.apache.org>
From: jerenkrantz@apache.org
To: apr-cvs@apache.org
Subject: cvs commit: apr/build apr_common.m4

jerenkrantz    2003/02/15 10:09:30

  Modified:    build    apr_common.m4
  Log:
  Fix a nice little autoconf bug where apr-util and pcre would not configure
  correctly upon updating to any recent version of autoconf.  (apr would
  configure correctly.)  (apr-util and pcre's configure would exit with
  syntax errors.)
  
  The only fix seems to be forcing a new shell to be invoked.  My hunch is
  that some shells have a limit to the buffer that it can contain.  This isn't
  helped by the fact that autoconf-2.54+ will reinvoke each configure script
  multiple times in order to try to find the 'best' shell to use.  Lame.
  
  Seen with Solaris/autoconf-2.54+.  (autoconf-2.54+ will use /bin/bash by
  default on these systems without a way to override.)
  
  Revision  Changes    Path
  1.51      +7 -2      apr/build/apr_common.m4
  
  Index: apr_common.m4
  ===================================================================
  RCS file: /home/cvs/apr/build/apr_common.m4,v
  retrieving revision 1.50
  retrieving revision 1.51
  diff -u -u -r1.50 -r1.51
  --- apr_common.m4	15 Jan 2003 14:00:55 -0000	1.50
  +++ apr_common.m4	15 Feb 2003 18:09:30 -0000	1.51
  @@ -102,8 +102,13 @@
       ac_sub_cache_file="$ac_popdir/$cache_file" ;;
     esac
   
  -  # The eval makes quoting arguments work.
  -  if eval $ac_abs_srcdir/configure $ac_configure_args --cache-file=$ac_sub_cache_file --srcdir=$ac_abs_srcdir $2
  +  dnl The eval makes quoting arguments work - specifically $2 where the
  +  dnl quoting mechanisms used is "" rather than [].
  +  dnl
  +  dnl We need to execute another shell because some autoconf/shell combinations
  +  dnl will choke after doing repeated APR_SUBDIR_CONFIG()s.  (Namely Solaris
  +  dnl and autoconf-2.54+)
  +  if eval $SHELL $ac_abs_srcdir/configure $ac_configure_args --cache-file=$ac_sub_cache_file --srcdir=$ac_abs_srcdir $2
     then :
       echo "$1 configured properly"
     else