apr-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From <...@apache.org>
Subject Re: cvs commit: apr/test testfile.c
Date Thu, 02 Jan 2003 15:09:02 GMT


Guys, this is ridiculus.  If a test fails, the correct approach is not to
remove the test from the test suite.  The hole point of the test suite is
to ensure that APR works the same on _ALL_ platforms.  If it doesn't, then
it is just as hard to write portable programs with APR as without.

There are two options when a test fails.  1)  Fix the bug in the APR code.
2)  Introduce a feature macro that allows programmers to determine if a
feature exists with #ifdefs.  Removing a test is _not_ an option.  It
weakens APR's portability.

Plus, not long after Will added this test, I posted to the list remarking
that it was a problematic test and looking for possible solutions.  We
should at least have a conversation over how we want to deal with this.

-1 for removing this test.

Ryan

On 2 Jan 2003 trawick@apache.org wrote:

> trawick     2003/01/02 06:05:42
>
>   Modified:    test     testfile.c
>   Log:
>   don't test whether or not the OS will let us open a directory
>   as a regular file...  that isn't controlled by APR and on some
>   platforms it will actually work
>
>   Revision  Changes    Path
>   1.67      +0 -14     apr/test/testfile.c
>
>   Index: testfile.c
>   ===================================================================
>   RCS file: /home/cvs/apr/test/testfile.c,v
>   retrieving revision 1.66
>   retrieving revision 1.67
>   diff -u -r1.66 -r1.67
>   --- testfile.c	1 Jan 2003 00:01:56 -0000	1.66
>   +++ testfile.c	2 Jan 2003 14:05:42 -0000	1.67
>   @@ -83,19 +83,6 @@
>        CuAssertPtrEquals(tc, NULL, thefile);
>    }
>
>   -static void test_open_dir_read(CuTest *tc)
>   -{
>   -    apr_status_t rv;
>   -    apr_file_t *thedir = NULL;
>   -
>   -    rv = apr_file_open(&thedir, DIRNAME,
>   -                       APR_READ,
>   -                       APR_UREAD | APR_UWRITE | APR_GREAD, p);
>   -    CuAssertTrue(tc, rv != APR_SUCCESS);
>   -    CuAssertIntEquals(tc, 1, APR_STATUS_IS_EACCES(rv));
>   -    CuAssertPtrEquals(tc, NULL, thedir);
>   -}
>   -
>    static void test_open_excl(CuTest *tc)
>    {
>        apr_status_t rv;
>   @@ -518,7 +505,6 @@
>        CuSuite *suite = CuSuiteNew("File I/O");
>
>        SUITE_ADD_TEST(suite, test_open_noreadwrite);
>   -    SUITE_ADD_TEST(suite, test_open_dir_read);
>        SUITE_ADD_TEST(suite, test_open_excl);
>        SUITE_ADD_TEST(suite, test_open_read);
>        SUITE_ADD_TEST(suite, test_open_readwrite);
>
>
>
>


Mime
View raw message