Return-Path: Delivered-To: apmail-apr-cvs-archive@apr.apache.org Received: (qmail 96169 invoked by uid 500); 23 Oct 2002 15:00:30 -0000 Mailing-List: contact cvs-help@apr.apache.org; run by ezmlm Precedence: bulk List-Post: List-Help: List-Unsubscribe: List-Subscribe: Reply-To: dev@apr.apache.org Delivered-To: mailing list cvs@apr.apache.org Received: (qmail 95997 invoked from network); 23 Oct 2002 15:00:28 -0000 Date: Wed, 23 Oct 2002 11:00:28 -0400 (EDT) From: rbb@apache.org X-Sender: rbb@shell.ntrnet.net To: Jeff Trawick Cc: dev@apr.apache.org, apr-cvs@apache.org Subject: Re: cvs commit: apr/test testpools.c In-Reply-To: Message-ID: MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII X-Spam-Rating: daedalus.apache.org 1.6.2 0/1000/N On 23 Oct 2002, Jeff Trawick wrote: > rbb@apache.org writes: > > > I actually considered doing this, but I don't believe that it is a good > > idea. The problem is the amount of information you get if things > > fail. With this change you get: > > > > 50 tests run: 49 passed, 1 failed, 0 not implemented. > > Failed tests: > > 1) calloc_bytes: assert failed > > > > Without it, you get: > > > > 50 tests run: 49 passed, 1 failed, 0 not implemented. > > Failed tests: > > 1) calloc_bytes: expected pointer <(nil)> but was <0x61> > > > > I would mucch rather have the added information. > > The previous code was not valid C. > > "testpools.c", line 101.37: 1506-280 (S) Function argument assignment > between types "void*" and "char" is not allowed. > > Maybe you want to add an appropriate flavor of CuAssert that checks > characters? Ok, I'll get this fixed today. Ryan _______________________________________________________________________________ Ryan Bloom rbb@apache.org 550 Jean St Oakland CA 94610 -------------------------------------------------------------------------------