apr-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Ryan Bloom" <...@covalent.net>
Subject RE: cvs commit: apr/network_io/win32 sendrecv.c
Date Mon, 15 Jul 2002 13:49:45 GMT
> From: wrowe@apache.org [mailto:wrowe@apache.org]
> 
> wrowe       2002/07/14 23:34:33
> 
>   Modified:    network_io/win32 sendrecv.c
>   Log:
>     The last transpostion of ->timeout into apr_time fixed a bug
> identified
>     by TANAKA Koichi <tanaka@ariel-networks.com>, where we used our
old ms
>     based timeout within the timeval structure usec member.
> 
>     This patch fixes the only exception to needing the timeout_ms.
NOTICE
>     that we first test that *timeout* is positive, since only then
will
>     timeout_ms contain anything worth using.

This is the exact kind of code that is likely to introduce bugs, and why
we shouldn't be duplicating the timeout value inside of APR.  At some
point, somebody is going to commit code to APR on Windows, that doesn't
use both values.

Ryan

 


Mime
View raw message