apr-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From jerenkra...@apache.org
Subject cvs commit: apr STATUS
Date Sat, 13 Apr 2002 06:34:08 GMT
jerenkrantz    02/04/12 23:34:08

  Modified:    .        STATUS
  My comment has nothing to do with versioning but rather a tendency
  to be conservative about things that could possibly fail - given an
  unknown implementation.  Our implementation can't fail, but a theoretical
  MD5 implementation could.  I've just been bit by too many locations in
  httpd where no return code was ever thought possible and we had to
  change the API to handle a return code when we did need it.
  Note that our md5 implementation has no business being in APR - it
  should be in apr-util with our "crypto" stuff there.  The overall goal
  of providing random bytes on all platforms (i.e. APR_HAS_RANDOM is always
  defined) would mean that we can kick md5 to its appropriate place - see
  note about where the fix needs to be.  So, if you "fix" the API, it might
  be goodness to move it to apr-util at the same time.
  Revision  Changes    Path
  1.110     +4 -2      apr/STATUS
  Index: STATUS
  RCS file: /home/cvs/apr/STATUS,v
  retrieving revision 1.109
  retrieving revision 1.110
  diff -u -r1.109 -r1.110
  --- STATUS	13 Apr 2002 06:12:33 -0000	1.109
  +++ STATUS	13 Apr 2002 06:34:08 -0000	1.110
  @@ -1,5 +1,5 @@
  -Last modified at [$Date: 2002/04/13 06:12:33 $]
  +Last modified at [$Date: 2002/04/13 06:34:08 $]
  @@ -344,10 +344,12 @@
         versioned, this api change is [somewhat] painful for httpd.
         Status: Still in discussion, current leanings appear to be
           Bill Stoddard -0.5 (?)
  -        Justin Erenkrantz -1
           Sander Striker -1 or -0.5 (?)
           Greg Stein +1
           Karl Fogel +1
         (Not sure if the negatives would stay negative given that the
         change would now wait for the library versioning thing described
         above, though.)
  +        Justin says: If you do this, please move it into apr-util where md5
  +                     belongs!  You'll have to address the random issue in
  +                     misc/unix/getuuid.c that forces md5 to be in APR.

View raw message