apr-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Ryan Bloom" <...@covalent.net>
Subject RE: cvs commit: apr-util/buckets apr_brigade.c
Date Wed, 10 Apr 2002 16:47:50 GMT
> From: jwoolley@apache.org [mailto:jwoolley@apache.org]
> Sent: Wednesday, April 10, 2002 9:44 AM
> To: apr-util-cvs@apache.org
> Subject: cvs commit: apr-util/buckets apr_brigade.c
> 
> jwoolley    02/04/10 09:44:11
> 
>   Modified:    buckets  apr_brigade.c
>   Log:
>   The brigade cleanup should only happen in the "normal" pool cleanup,
not
>   in the child cleanup.

Why is this?  The point of the child_cleanup is to clean pools before we
execute another program.  IMHO, we should definitely be destroying the
brigade in that case.

Ryan


> 
>   Reviewed by: Sander Striker
> 
>   Revision  Changes    Path
>   1.38      +1 -1      apr-util/buckets/apr_brigade.c
> 
>   Index: apr_brigade.c
>   ===================================================================
>   RCS file: /home/cvs/apr-util/buckets/apr_brigade.c,v
>   retrieving revision 1.37
>   retrieving revision 1.38
>   diff -u -d -u -r1.37 -r1.38
>   --- apr_brigade.c	29 Mar 2002 08:12:08 -0000	1.37
>   +++ apr_brigade.c	10 Apr 2002 16:44:10 -0000	1.38
>   @@ -108,7 +108,7 @@
> 
>        APR_RING_INIT(&b->list, apr_bucket, link);
> 
>   -    apr_pool_cleanup_register(b->p, b, brigade_cleanup,
> brigade_cleanup);
>   +    apr_pool_cleanup_register(b->p, b, brigade_cleanup,
> apr_pool_cleanup_null);
>        return b;
>    }
> 
> 
> 
> 


Mime
View raw message