apr-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From wr...@apache.org
Subject cvs commit: apr/threadproc/win32 proc.c
Date Fri, 22 Mar 2002 07:55:00 GMT
wrowe       02/03/21 23:55:00

  Modified:    threadproc/win32 proc.c
  Log:
    Stub in the warning and observations.
  
  Revision  Changes    Path
  1.71      +5 -0      apr/threadproc/win32/proc.c
  
  Index: proc.c
  ===================================================================
  RCS file: /home/cvs/apr/threadproc/win32/proc.c,v
  retrieving revision 1.70
  retrieving revision 1.71
  diff -u -r1.70 -r1.71
  --- proc.c	22 Mar 2002 07:53:03 -0000	1.70
  +++ proc.c	22 Mar 2002 07:55:00 -0000	1.71
  @@ -446,6 +446,11 @@
               }
               i = strlen(progname);
               if (i >= 11 && strcasecmp(progname + i - 11, "command.com") == 0)
{
  +                /* XXX: Still insecure - need doubled-quotes on each individual
  +                 * arg of cmdline.  Suspect we need to postpone cmdline parsing
  +                 * until this moment in all four code paths, with some flags
  +                 * to toggle 'which flavor' is needed.
  +                 */
                   cmdline = apr_pstrcat(pool, shellcmd, " /C ", argv0, cmdline, NULL);
               }
               else {
  
  
  

Mime
View raw message