Mailing-List: contact cvs-help@apr.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@apr.apache.org
Date: 30 Jan 2002 15:33:14 -0000
Message-ID: <20020130153314.60075.qmail@icarus.apache.org>
From: aaron@apache.org
To: apr-cvs@apache.org
Subject: cvs commit: apr/shmem/unix shm.c

aaron       02/01/30 07:33:14

  Modified:    shmem/unix shm.c
  Log:
  Fixed up some comments -- got rid of FIXMEs that have been fixed.
  
  Revision  Changes    Path
  1.12      +1 -6      apr/shmem/unix/shm.c
  
  Index: shm.c
  ===================================================================
  RCS file: /home/cvs/apr/shmem/unix/shm.c,v
  retrieving revision 1.11
  retrieving revision 1.12
  diff -u -r1.11 -r1.12
  --- shm.c	29 Jan 2002 01:16:11 -0000	1.11
  +++ shm.c	30 Jan 2002 15:33:14 -0000	1.12
  @@ -152,9 +152,6 @@
       apr_file_t *file;   /* file where metadata is stored */
   #endif
   
  -    /* FIXME: associate this thing with a pool and set up a destructor
  -     * to call detach. */
  -
       /* Check if they want anonymous or name-based shared memory */
       if (filename == NULL) {
   #if APR_USE_SHMEM_MMAP_ZERO || APR_USE_SHMEM_MMAP_ANON
  @@ -474,8 +471,6 @@
           new_m->pool = pool;
           new_m->filename = apr_pstrdup(pool, filename);
   
  -        /* FIXME: open the file, read the length, mmap the segment,
  -         *        close the file, reconstruct the apr_shm_t. */
           status = apr_file_open(&file, filename, 
                                  APR_READ | APR_WRITE,
                                  APR_OS_DEFAULT, pool);
  @@ -512,7 +507,7 @@
               return status;
           }
   
  -        /* metadata isn't usable */
  +        /* metadata isn't part of the usable segment */
           new_m->usable = new_m->base + sizeof(apr_size_t);
   
           apr_pool_cleanup_register(new_m->pool, new_m, shm_cleanup_attach,