Return-Path: Delivered-To: apmail-apr-cvs-archive@apr.apache.org Received: (qmail 2671 invoked by uid 500); 28 Dec 2001 22:28:17 -0000 Mailing-List: contact cvs-help@apr.apache.org; run by ezmlm Precedence: bulk List-Post: List-Help: List-Unsubscribe: List-Subscribe: Reply-To: dev@apr.apache.org Delivered-To: mailing list cvs@apr.apache.org Received: (qmail 2660 invoked from network); 28 Dec 2001 22:28:17 -0000 Date: 28 Dec 2001 22:28:17 -0000 Message-ID: <20011228222817.3898.qmail@icarus.apache.org> From: wrowe@apache.org To: apr-cvs@apache.org Subject: cvs commit: apr/file_io/os2 filestat.c X-Spam-Rating: daedalus.apache.org 1.6.2 0/1000/N wrowe 01/12/28 14:28:16 Modified: file_io/os2 filestat.c Log: FS3_to_finfo already assigns the initial valid bits. It makes no sense to define that APR_FINFO_IDENT bits are there, when OS2 can't support them. Since the APR_INCOMPLETE result is _supposed_ to warn the program that some extra action might be required, it is safest to leave those bits unset, and let the program deal with things as it will. Revision Changes Path 1.25 +3 -4 apr/file_io/os2/filestat.c Index: filestat.c =================================================================== RCS file: /home/cvs/apr/file_io/os2/filestat.c,v retrieving revision 1.24 retrieving revision 1.25 diff -u -r1.24 -r1.25 --- filestat.c 19 Sep 2001 16:01:39 -0000 1.24 +++ filestat.c 28 Dec 2001 22:28:16 -0000 1.25 @@ -82,8 +82,9 @@ fstatus->ftimeLastWrite ); apr_os2_time_to_apr_time(&finfo->ctime, fstatus->fdateCreation, fstatus->ftimeCreation ); - finfo->valid |= APR_FINFO_TYPE | APR_FINFO_PROT | APR_FINFO_SIZE | - APR_FINFO_CSIZE | APR_FINFO_MTIME | APR_FINFO_CTIME | APR_FINFO_ATIME; + finfo->valid = APR_FINFO_TYPE | APR_FINFO_PROT | APR_FINFO_SIZE + | APR_FINFO_CSIZE | APR_FINFO_MTIME + | APR_FINFO_CTIME | APR_FINFO_ATIME; } @@ -129,8 +130,6 @@ if (rc == 0) { FS3_to_finfo(finfo, &fstatus); - /* XXX: This is wrong, but it will work for today */ - finfo->valid = APR_FINFO_NORM; if (finfo->filetype == APR_REG) { if (thefile->isopen) {